This repository has been archived by the owner on May 22, 2024. It is now read-only.
Active users #411
Merged
Active users #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rultor merge |
@g4s8 Oops, I failed. You can see the full log here (spent 4min) |
|
This pull request #411 is assigned to @victornoel/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @g4s8/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
victornoel
reviewed
Apr 17, 2020
There was a problem hiding this comment.
@g4s8 just one comment for now, and also, shouldn't we add @todos to continue the work?
| <user id="0crat"> | ||
| <activated>2016-12-29T09:03:21.684Z</activated> | ||
| </user> | ||
| </users> |
There was a problem hiding this comment.
@g4s8 I'm not clear what this file is for?
There was a problem hiding this comment.
@victornoel this file is like a test resource, the build is running xsd schema against this file and checks that it's valid
There was a problem hiding this comment.
@g4s8 ah indeed, sorry I now realise the README explains that. So the work is finished for that task or do we need todos (or maybe you will be making multiple PRs?)?
There was a problem hiding this comment.
@victornoel yes, it's finished in this repo. It'll be continued in farm: https://github.com/zerocracy/farm/issues/2245
There was a problem hiding this comment.
@g4s8 I understand, thank you for the explanation :)
|
@g4s8 ping |
victornoel
approved these changes
Apr 23, 2020
|
@rultor merge |
@g4s8 Oops, I failed. You can see the full log here (spent 3min) |
|
@g4s8 can we get this merged? It's taking space in my agenda :) |
|
@g4s8 ping |
1 similar comment
|
@g4s8 ping |
|
@g4s8 can we get this one merged please? |
|
@rultor merge |
@g4s8 Oops, I failed. You can see the full log here (spent 7min) |
|
@rultor merge |
|
@sereshqua/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
@victornoel please make sure you will find at least 3 issues during next CR, thanks |
|
@sereshqua yes, thx |
|
@0crat quality acceptable |
|
Order was finished, quality is "acceptable": +15 point(s) just awarded to @victornoel/z |
|
Quality review completed: +4 point(s) just awarded to @sereshqua/z |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#410 - added active users file