Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options.java:37-39: Options should be changeable by the... #1186

Closed
0pdd opened this issue Jun 19, 2018 · 18 comments
Closed

Options.java:37-39: Options should be changeable by the... #1186

0pdd opened this issue Jun 19, 2018 · 18 comments

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jun 19, 2018

The puzzle 1035-a9c9989f from #1035 has to be resolved:

* @todo #1035:30min Options should be changeable by the user from their profile
* page. Allow users to download, edit and upload options.xml file on profile
* page.

The puzzle was created by Krzysztof Krason on 15-Jun-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0crat
Copy link
Collaborator

0crat commented Jun 19, 2018

@g4s8/z please, pay attention to this issue

@0crat 0crat added the scope label Jun 19, 2018
@0crat
Copy link
Collaborator

0crat commented Jun 19, 2018

Job #1186 is now in scope, role is DEV

@krzyk
Copy link
Contributor

krzyk commented Jul 18, 2018

@g4s8 I think it would be better for users to be able to change the options using 0crat in telegram not by uploading files. Was the file upload chosen as the easier option?

@g4s8
Copy link
Collaborator

g4s8 commented Jul 18, 2018

@krzyk I suppose we choose file upload because of easier implementation comparing to chat bot commands, because we need to add many new commands for each option

@krzyk
Copy link
Contributor

krzyk commented Jul 18, 2018

@g4s8 wouldn't it be enough to have a generic command like this?

  <cmd>
    <code>Change option</code>
    <regex>option</regex>
    <label>otion</label>
    <help>Change user options</help>
    <invited>true</invited>
    <opts>
      <opt>
        <name>name</name>
        <regex>[A-Z]{3,}</regex>
        <help>Option name</help>
      </opt>
      <opt>
        <name>value</name>
        <regex>[a-zA-Z0-9]+</regex>
        <help>Option value</help>
      </opt>
    </opts>
  </cmd>

It could print the list of available options on failure (and type of value).

@g4s8
Copy link
Collaborator

g4s8 commented Jul 18, 2018

@krzyk you're right, it would be much easier. Didn't think about it. Let's do as you suggested.

@g4s8
Copy link
Collaborator

g4s8 commented Jul 18, 2018

@0crat assign @krzyk

@0crat
Copy link
Collaborator

0crat commented Jul 18, 2018

@0crat assign @krzyk (here)

@g4s8 The job #1186 assigned to @krzyk/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Jul 18, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @g4s8/z

krzyk added a commit to krzyk/farm that referenced this issue Jul 19, 2018
krzyk added a commit to krzyk/farm that referenced this issue Jul 19, 2018
krzyk added a commit to krzyk/farm that referenced this issue Jul 21, 2018
krzyk added a commit to krzyk/farm that referenced this issue Jul 22, 2018
@0crat
Copy link
Collaborator

0crat commented Jul 23, 2018

@krzyk/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 24, 2018

@0pdd the puzzle #1472 is still not solved.

krzyk added a commit to krzyk/farm that referenced this issue Jul 24, 2018
g4s8 added a commit that referenced this issue Jul 24, 2018
@0pdd 0pdd closed this as completed Jul 24, 2018
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 24, 2018

The puzzle 1035-a9c9989f has disappeared from the source code, that's why I closed this issue.

@0crat
Copy link
Collaborator

0crat commented Jul 24, 2018

@ypshenychka/z please review this job completed by @krzyk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Jul 24, 2018
@0crat
Copy link
Collaborator

0crat commented Jul 24, 2018

The job #1186 is now out of scope

@ypshenychka
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Jul 24, 2018

Order was finished, quality is "good": +35 point(s) just awarded to @krzyk/z

@0crat
Copy link
Collaborator

0crat commented Jul 24, 2018

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 15, 2022

@0pdd the puzzle #unknown is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants