Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete_stale_jobs.groovy:35-41: Cleanup of stale jobs is... #1448

Closed
0pdd opened this issue Jul 20, 2018 · 11 comments
Closed

delete_stale_jobs.groovy:35-41: Cleanup of stale jobs is... #1448

0pdd opened this issue Jul 20, 2018 · 11 comments
Milestone

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 20, 2018

The puzzle 1414-beb41dc9 from #1414 has to be resolved:

// @todo #1414:30min Cleanup of stale jobs is disabled for QA roles.
// This is because QA jobs are not in Orders, but in Reviews. This
// causes a bug where QA agenda is removed even though the jobs have
// not completed review yet. For QA roles, get the list of jobs from
// Reviews.findByInspector(). Let's also add a Bundles test case
// where delete_stale_jobs should clean up jobs that are not in
// Reviews and retains those that are still awaiting verdict.

The puzzle was created by Carlos Miranda on 19-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0crat
Copy link
Collaborator

0crat commented Jul 20, 2018

@g4s8/z please, pay attention to this issue

@0crat 0crat added the scope label Jul 20, 2018
@0crat
Copy link
Collaborator

0crat commented Jul 20, 2018

Job #1448 is now in scope, role is DEV

@g4s8 g4s8 added this to the launch milestone Aug 6, 2018
@0crat
Copy link
Collaborator

0crat commented Aug 8, 2018

The job #1448 assigned to @paulodamaso/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

paulodamaso added a commit to paulodamaso/zerocracy-farm that referenced this issue Aug 9, 2018
paulodamaso added a commit to paulodamaso/zerocracy-farm that referenced this issue Aug 9, 2018
paulodamaso added a commit to paulodamaso/zerocracy-farm that referenced this issue Aug 10, 2018
paulodamaso added a commit to paulodamaso/zerocracy-farm that referenced this issue Aug 10, 2018
paulodamaso added a commit to paulodamaso/zerocracy-farm that referenced this issue Aug 10, 2018
@0pdd
Copy link
Collaborator Author

0pdd commented Aug 13, 2018

The puzzle 1414-beb41dc9 has disappeared from the source code, that's why I closed this issue.

@0crat
Copy link
Collaborator

0crat commented Aug 13, 2018

@ypshenychka/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Aug 13, 2018
@0crat
Copy link
Collaborator

0crat commented Aug 13, 2018

The job #1448 is now out of scope

@krzyk
Copy link
Contributor

krzyk commented Aug 13, 2018

@ypshenychka Did this change help with your agenda cleanup? I'm asking because it didn't in my case, I still see e.g. #1352 (and few others) as assigned to you in my agenda

@ypshenychka
Copy link

@krzyk Looks like only one redundant task is still in my agenda. #1474 wasn't cleaned up

@ypshenychka
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Aug 13, 2018

Order was finished, quality is "good": +35 point(s) just awarded to @paulodamaso/z

@0crat
Copy link
Collaborator

0crat commented Aug 13, 2018

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants