Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's Jacoco enforces minimum code coverage #474

Closed
fabriciofx opened this issue Jan 26, 2018 · 16 comments
Closed

Let's Jacoco enforces minimum code coverage #474

fabriciofx opened this issue Jan 26, 2018 · 16 comments
Labels

Comments

@fabriciofx
Copy link
Contributor

It's a common problem submit PRs and them not pass in Codecov. I think this problem could be minimized if Jacoco enforces minimum code coverage, as you can check here. Thus, you can check if the minimum code coverage is reach before submit your PR.

@0crat
Copy link
Collaborator

0crat commented Jan 26, 2018

@yegor256/z please, pay attention to this issue

@yegor256
Copy link
Member

@fabriciofx I agree, see how it works in Cactoos: yegor256/cactoos#250

@yegor256 yegor256 added the bug label Jan 26, 2018
@0crat
Copy link
Collaborator

0crat commented Jan 26, 2018

Job #474 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Jan 26, 2018

Bug was reported, see §29: +15 points just awarded to @fabriciofx/z, total is +315

@0crat
Copy link
Collaborator

0crat commented Feb 16, 2018

The job #474 assigned to @g4s8/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

@g4s8
Copy link
Collaborator

g4s8 commented Feb 20, 2018

@fabriciofx PR #593 was merged, todo #613 was submitted, can we close?

@0crat
Copy link
Collaborator

0crat commented Feb 21, 2018

@g4s8/z this job was assigned to you 5 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@g4s8
Copy link
Collaborator

g4s8 commented Feb 24, 2018

@yegor256 could you please close this issue? PR #593 was merged and new todo #613 was created.

@0crat
Copy link
Collaborator

0crat commented Feb 24, 2018

@g4s8/z this job was assigned to you 8 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@g4s8
Copy link
Collaborator

g4s8 commented Feb 25, 2018

@0crat waiting for close

@0crat
Copy link
Collaborator

0crat commented Feb 25, 2018

@0crat waiting for close (here)

@g4s8 The impediment for #474 was registered successfully by @g4s8/z

@yegor256
Copy link
Member

@g4s8 thanks!

@0crat
Copy link
Collaborator

0crat commented Feb 26, 2018

Order was finished, quality was "acceptable": +30 points just awarded to @g4s8/z, total is +4675

@0crat
Copy link
Collaborator

0crat commented Feb 26, 2018

The job #474 is now out of scope

@0pdd
Copy link
Collaborator

0pdd commented Jun 4, 2018

@fabriciofx the puzzle #1083 is still not solved; solved: #613.

@0pdd
Copy link
Collaborator

0pdd commented Jul 6, 2018

@fabriciofx the puzzle #1351 is still not solved; solved: #1083, #613.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants