Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add basket order margins #49

Merged
merged 4 commits into from
Jun 21, 2021
Merged

feat: add basket order margins #49

merged 4 commits into from
Jun 21, 2021

Conversation

ranjanrak
Copy link
Member

  • Refactored request method to receive query params along with JSON payload using queryParams object.
  • Added basket order margin API.
  • Add example for basket order margin API.

@ranjanrak ranjanrak mentioned this pull request Jun 21, 2021
Closed
hackvish
hackvish reviewed Jun 21, 2021
View reviewed changes
lib/connect.js Outdated Show resolved Hide resolved
@vividvilla vividvilla merged commit 6ae2950 into zerodha:master Jun 21, 2021
@ranjanrak ranjanrak mentioned this pull request Jun 22, 2021
Closed
@mgnanaprakash11
Copy link

Hello,

     I'm getting this error.
     kc.orderBasketMargins is not a function

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackvish hackvish hackvish left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ranjanrak @mgnanaprakash11 @hackvish @vividvilla