Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging -> Need a tagged version #108

Closed
SylvainCorlay opened this issue Jan 16, 2017 · 7 comments
Closed

Packaging -> Need a tagged version #108

SylvainCorlay opened this issue Jan 16, 2017 · 7 comments

Comments

@SylvainCorlay
Copy link
Contributor

As per discussion on #107, I would like to package cppzmq for conda, it would be very nice to have a tagged version on GitHub, to have a fixed version of the code to refer to.

One thing that would help is that the tag always follow the same pattern and can be completely deduced from the version number. (typically M.m.p).

@JohanMabille
Copy link
Contributor

That would really help with packaging.

@bluca
Copy link
Member

bluca commented Jan 17, 2017

Still not 100% sure it makes sense to tag this repository, but if it helps some use cases don't see why not. Pushed v4.2.1 to make it match libzmq

@bluca bluca closed this as completed Jan 17, 2017
@SylvainCorlay
Copy link
Contributor Author

Awesome. This is for the reproducible builds of conda-forge.

@SylvainCorlay
Copy link
Contributor Author

@bluca FYI, cppzmq has been packaged for conda:

conda install cppzmq -c conda-forge

@bluca
Copy link
Member

bluca commented Jan 28, 2017

Fantastic, thank you very much for your work!

@SylvainCorlay
Copy link
Contributor Author

SylvainCorlay commented Jan 28, 2017 via email

@SylvainCorlay
Copy link
Contributor Author

Quick note on the packaging as we just updated the conda packages for zeromq and cppzmq: cppzmq 4.2.2 works fine with zeromq 4.2.3, which is just a patch release. I think it makes sense for the version numbers of the two packages to be decorrelated and have a clear dependency requirement on zeromq, i.e.

cppzmq 4.2.2 depends on zeromq >=4.2.1,<4.3.0...

or every single patch release of zeromq will require a corresponding cppzmq release, and you won't be able to make releases for cppzmq only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants