-
Notifications
You must be signed in to change notification settings - Fork 789
Cmake files #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmake files #107
Conversation
Hi, I think this header was intended to be used together with libzmq, so I'm not sure it should have its own build system with its own name and version |
Just like any libzmq binding. However they all have their dedicated build, version number and packaging. Actually this is not a full build system. The Without this, any package working with cppzmq would require a manual installation of it, making it impossible to have clean CI, scripted installation and so on. |
Hum, as soon as it is not distributed with the zmq package and can have its own updates, it makes sense to have independent versioning from zmq. |
@bluca would it be ok if I set the version to be the same as libzmq ? So we don't have to worry about it, and we still have the cmake packaging and installation feature. |
Yes please, that would make it clearer that they are intended to be used in lock steps |
@bluca, I am looking at packaging cppzmq for conda. Would you consider
|
First of all I am really not very involved with the development of this repository, basically I am a passer-by with strong opinions and access to the green buttons :-) My main concern is compatibility. For example in CZMQ we have a build time and runtime detection system to ensure compatibility with all supported versions of libzmq. I don't think there's anything like that in this project. If you can confirm that the current version of cppzmq works with libzmq 4.1.2, I can tag with the same number. |
OK I see where you come from. The required version range for libzmq could be specified in the cmake and the docs. - It sounds like a good idea to start from the same number as the latest compatible libzmq version. Since libzmq follows semver, any major version number of libzmq should trigger a major version number change in cppzmq. |
@bluca it does work - but we have mostly been using zeromq master. A github tag would be fantastic... |
This PR adds cmake files for installing cppzmq (and be able to find it via
find_package(cppzmq)
).I've added version number in
zmq.hpp
and set it to1.0.0
since there doesn't seem to be any tag / version number yet, and I don't know what the version policy should be.