Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC 11 projects #131

Merged
merged 3 commits into from
Apr 1, 2013
Merged

MSVC 11 projects #131

merged 3 commits into from
Apr 1, 2013

Conversation

TTimo
Copy link
Contributor

@TTimo TTimo commented Mar 31, 2013

Converted the current project files to MSVC 11, and fixed the various configurations.
I don't have MSVC 10 at hand, but the same configuration fixes should be applied there.

hintjens added a commit that referenced this pull request Apr 1, 2013
@hintjens hintjens merged commit d8b5133 into zeromq:master Apr 1, 2013
@hintjens
Copy link
Member

hintjens commented Apr 1, 2013

Awesome, thanks!

@vortechs2000
Copy link
Contributor

Thanks! I'll send a pull request with the fix for the czmq.sln multithreaded library type.

@TTimo
Copy link
Contributor Author

TTimo commented Apr 1, 2013

Note that there may be a few other things to adjust. The czmq project on
MSVC 11 is now organized the way I've seen most modern MSVC projects
organized: Debug DebugDLL Release ReleaseDLL folders etc. .. but the libzmq
project is done a different way .. the static/dynamic configuration goes to
either lib/win32 and bin/win32, then the debug configuration output uses a
_d in the filename (libzmq_d.lib).

On Mon, Apr 1, 2013 at 8:52 AM, AJ Lewis notifications@github.com wrote:

Thanks! I'll send a pull request with the fix for the czmq.sln
multithreaded library type.


Reply to this email directly or view it on GitHubhttps://github.com//pull/131#issuecomment-15715994
.

@vortechs2000
Copy link
Contributor

And using CMake to build libzmq (which is how I do it) you get libzmq-v90-mt-3_2_2.dll in the lib dir.

Any chance you'd be open to just using CMake to generate the VS files - it certainly makes maintaining consistency between builds on different versions of visual studio a lot easier.

@TTimo
Copy link
Contributor Author

TTimo commented Apr 1, 2013

I don't like CMake much. If it's the primary build system of a project, I
don't mind dealing with it and maintaining it, but you won't see me promote
it's use.

Also it would be weird having CMake for Windows+MSVC only, we would have to
support it as a build option across all the supported platforms. I'd much
rather maintain MSVC project files at that point :)

TTimo

On Mon, Apr 1, 2013 at 10:26 AM, AJ Lewis notifications@github.com wrote:

And using CMake to build libzmq (which is how I do it) you get
libzmq-v90-mt-3_2_2.dll in the lib dir.

Any chance you'd be open to just using CMake to generate the VS files - it
certainly makes maintaining consistency between builds on different
versions of visual studio a lot easier.


Reply to this email directly or view it on GitHubhttps://github.com//pull/131#issuecomment-15719921
.

@vortechs2000
Copy link
Contributor

libzmq uses it just for Windows AFAIK. Kind of weird, yes, but it doesn't seem to have been a problem.

The thing I hate about the pure MSVC solution files is that we have to maintain files for each version of VS we want to support. I'm stuck on MSVC 9.0 ATM, and now we have MSVC 11 .sln files. What about those on MSVC 10? Presumably that'll work with the MSVC 9.0 files, but for those that want to adjust and contribute using MSVC 10, it ends up being a pain. Is there better way to manage this will pure .sln files?

With CMake, we'd have a single source for all supported MSVC generators, but it has its own share of issues, and a reasonably steep learning curve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants