Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autotools build on Cygwin #1798

Merged
merged 2 commits into from
Nov 26, 2017
Merged

Fix autotools build on Cygwin #1798

merged 2 commits into from
Nov 26, 2017

Conversation

gitplcc
Copy link
Contributor

@gitplcc gitplcc commented Nov 26, 2017

Fix autotools build on Cygwin failing due to:

  • O_BINARY symbol redefinition in include/czmq_prelude.h
  • attribute ((visibility ("hidden"))) not supported by Windows executables.

Signed-off-by: Pedro Luis Castedo Cepeda <pedroluis.castedo@upm.es>
"hidden" is not supported by Windows executables.

Signed-off-by: Pedro Luis Castedo Cepeda <pedroluis.castedo@upm.es>
@gitplcc gitplcc changed the title Feature/cygwin Fix autotools build on Cygwin Nov 26, 2017
@bluca bluca merged commit 284a97e into zeromq:master Nov 26, 2017
@bluca
Copy link
Member

bluca commented Nov 26, 2017

Thanks but as the header says the first file is generated so your change will be overwritten, you need to fix it in https://github.com/zeromq/zproject

@gitplcc gitplcc deleted the feature/cygwin branch November 26, 2017 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants