Merge pull request #707 from daveyarwood/improve-sad-path-address-res…

…olution-tests Improve sad path address resolution tests
zeromq · Apr 3, 2019 · 0fdcb58 · 0fdcb58
2 parents 46b2042 + 877fc08
commit 0fdcb58
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/test/java/zmq/io/net/TestAddress.java b/src/test/java/zmq/io/net/TestAddress.java
@@ -5,6 +5,7 @@
 import static org.junit.Assert.assertTrue;
 
 import org.junit.Test;
+import org.zeromq.ZMQException;
 
 public class TestAddress
 {
@@ -24,4 +25,10 @@ public void testResolvedToString()
         String resolved = addr.toString();
         assertTrue(resolved.matches("tcp://\\d+\\.\\d+\\.\\d+\\.\\d+:90"));
     }
+
+    @Test(expected = ZMQException.class)
+    public void testInvalid()
+    {
+        new Address("tcp", "ggglocalhostxxx.google.com:80").resolve(false);
+    }
 }
diff --git a/src/test/java/zmq/io/net/tcp/TcpAddressTest.java b/src/test/java/zmq/io/net/tcp/TcpAddressTest.java
@@ -96,6 +96,21 @@ public void testGoodIP46Google()
         Assert.assertEquals(80, sa.getPort());
     }
 
+    @Test
+    public void testBad()
+    {
+        try {
+            Address addr = new Address(NetProtocol.tcp.name(), "ggglocalhostxxx.google.com:80");
+            addr.resolve(true);
+            addr.resolved();
+            Assert.fail();
+        }
+        catch (ZMQException e) {
+            Assert.assertEquals(ZError.EADDRNOTAVAIL, e.getErrorCode());
+            Assert.assertEquals(e.getCause().getMessage(), e.getMessage());
+        }
+    }
+
     @Test
     public void testUnspecifiedIPv6DoubleColon() throws IOException
     {