mvn clean install fails on error in testcase #1
Comments
|
what is your java version? I tested with jdk1.6.0_33 and I didn't got the error. |
|
|
|
Platform: Mac OSX 10.8 java version "1.7.0_06" |
|
I think I need to test more on java7. michaelklishin, what was your mvn test result? here are known test failures at a certain network configuration. I'm going to ignore them. Failed tests: |
|
I am running on Java 6 (java version "1.6.0_33") on OS X 10.8. testProxyTcp() is getting stuck because of this IOException. If I ignore this test, all other tests pass. Exception in thread "iothread-2" zmq.ZException$IOException: java.io.IOException: Broken pipe |
|
Please ignore my last comment, I did not update your changes today. After pulling latest code base, I am able to run the tests fine. All tests pass for me on Java 6. |
|
kwo, It looks like your maven might choose openjdk. getRemoteAddress exist only at openjdk's SocketChannel. My test with oracle jdk7 works fine. $ mvn -version |
|
I believe the problem is, there were several new APIs added to SocketChannel in JDK 7. DummySocketChannel has to implement all those new methods in order to compile under JDK 7. getRemoteAddress() in SocketChannel (http://docs.oracle.com/javase/7/docs/api/java/nio/channels/SocketChannel.html#getRemoteAddress()) is a standard API that was introduced in JDK 7. mvn test fails for me under Oracle JDK 7 due to this incompatibility. The only way I can think of is to stick with either JDK 6 or JDK 7, it is not possible to support both unfortunately. |
|
Ah, you're right. I didn't look into jdk7 doc deeply and I forgot to run mvn clean. I just simply added getRemoteAddress at the dummy channel. Please pull the latest |
|
@aruld is right: in JDK 7, there is a method added to java.nio.channels.SocketChannel that has java.net.SocketOption in the signature. That class is new in JDK 7. This means, in jeromq's particular case, tests won't compile under JDK 6 (the library should work fine). Because JDK 7 is inevitable future and the only (recent) JDK you can get for recent OS X releases, I'd recommend going with 7 for development. These changes to the dummy channel are sufficient: diff --git a/src/test/java/zmq/Helper.java b/src/test/java/zmq/Helper.java
index 0c34d1c..7d52b74 100644
--- a/src/test/java/zmq/Helper.java
+++ b/src/test/java/zmq/Helper.java
@@ -25,11 +25,13 @@ import java.io.InputStream;
import java.io.OutputStream;
import java.net.Socket;
import java.net.SocketAddress;
+import java.net.SocketOption;
import java.nio.ByteBuffer;
import java.nio.channels.SocketChannel;
import java.nio.channels.spi.SelectorProvider;
import java.util.ArrayList;
import java.util.List;
+import java.util.Set;
import java.util.concurrent.atomic.AtomicInteger;
import static org.junit.Assert.*;
import static org.hamcrest.CoreMatchers.*;
@@ -49,8 +51,43 @@ public class Helper {
protected DummySocketChannel(SelectorProvider provider) {
super(provider);
}
-
- public DummySocketChannel() {
+
+ @Override
+ public SocketChannel bind(SocketAddress local) throws IOException {
+ return null;
+ }
+
+ @Override
+ public SocketAddress getLocalAddress() throws IOException {
+ return null;
+ }
+
+ @Override
+ public <T> SocketChannel setOption(SocketOption<T> name, T value) throws IOException {
+ return null;
+ }
+
+ @Override
+ public <T> T getOption(SocketOption<T> name) throws IOException {
+ return null;
+ }
+
+ @Override
+ public Set<SocketOption<?>> supportedOptions() {
+ return null;
+ }
+
+ @Override
+ public SocketChannel shutdownInput() throws IOException {
+ return null;
+ }
+
+ @Override
+ public SocketChannel shutdownOutput() throws IOException {
+ return null;
+ }
+
+ public DummySocketChannel() {
this(64);
}
public DummySocketChannel(int bufsize) { |
|
I uninstalled OpenJDK as I wasn't sure which JVM maven was using. I pulled just now and am still getting an error albeit a different one: [ERROR] /Users/karl/projects/jeromq/src/test/java/zmq/Helper.java:[45,18] error: DummySocketChannel is not abstract and does not override abstract method shutdownOutput() in SocketChannel |
|
@kwo It won't work until all the abstract methods are implemented from JDK 7 SocketChannel (shown in @michaelklishin patch). I personally think Java 6 should be supported as it is widely used everywhere. I see the DummySocketChannel is only used in tests (TestEncoder), is there a different approach to implement those tests? |
|
One way is to replace that dummy channel with a mock (since it already does not do much). JDK 6 will be supported, the issue is with a particular part of the test suite, not the library. |
|
Thanks for ideas. I narrowed down base class of DummySocketChannel from SocketChannel to WritableByteChannel. WritableByteChannel is jdk6/7 compatible. |
|
Just pulled and all tests pass on JDK7 |
|
also tested on 1.6.0_33 and all tests pass |
|
Closing issue: works on both JDK6 and 7 |
|
Now that both JDK 6 and JDK 7 are supported, I recommend adding jeromq to travis-ci.org to run CI against 3 JDKs: I will be happy to help if you have questions. |
Cannot compile without deactivating the test cases. Error is follows
[ERROR] .../jeromq/src/test/java/zmq/Helper.java:[25,18] error: DummySocketChannel is not abstract and does not override abstract method getRemoteAddress() in SocketChannel
The text was updated successfully, but these errors were encountered: