#412 tcp accept filter null pointer exception fix #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjamesturner
added a commit
to tjamesturner/jeromq
that referenced
this pull request
Mar 31, 2017
trevorbernard
added a commit
that referenced
this pull request
Apr 1, 2017
#413 ZMQ.ZMQ_TCP_ACCEPT_FILTER NullPointerException fix changelog update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple fix for #412 . i am only changing 1 private method (
TcpListener::accept). that method is only used in one place. i am changing the method to throw anIOExceptioninstead of returning null. returning null is guaranteed to cause aNullPoinerExceptionwhich is guaranteed to stop thePoller::runloop. anIOExceptionwill instead be caught by an existing catch block inTcpListener::acceptEventand handled gracefully (sent to the monitor socket or ignored).