Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the tag field in zmq.Ctx and zmq.SocketBase #661

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Removed the tag field in zmq.Ctx and zmq.SocketBase #661

merged 1 commit into from
Feb 16, 2019

Conversation

fbacchella
Copy link
Contributor

It's should be a boolean and it's really a flag that they object is active instead.

@fbacchella
Removed the tag field
b32dd11 
It's should be a boolean and it's really a flag that they object is active instead.
@coveralls
Copy link

coveralls commented Feb 16, 2019 •
edited

Coverage Status

Coverage decreased (-0.1%) to 84.199% when pulling b32dd11 on fbacchella:remove_tag into 6098762 on zeromq:master.

daveyarwood
daveyarwood approved these changes Feb 16, 2019
View reviewed changes
Copy link
Contributor

@daveyarwood daveyarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I 100% agree 👍

@daveyarwood daveyarwood merged commit b3b6bc0 into zeromq:master Feb 16, 2019
@fbacchella fbacchella deleted the remove_tag branch February 16, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveyarwood daveyarwood daveyarwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fbacchella @coveralls @daveyarwood