Improved IPv6 and name resolution handling #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbacchella
force-pushed
the
ipv6_improved
branch
3 times, most recently
from
1e2a65e
to
6bb0248
Compare
daveyarwood
requested changes
Feb 27, 2019
The actual way to handle IPv6 connectiont could be improved, a lot of code had no effect. All the IPv6/IPv4 choice should be done in name resolution. Error handling of failed name is improved too, a ZMQException is used. Trying to cover many more test case in TCP name resolution.
fbacchella
force-pushed
the
ipv6_improved
branch
from
6bb0248
to
d80d9cc
Compare
daveyarwood
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual way to handle IPv6 connectiont could be improved, a lot of code
had no effect. All the IPv6/IPv4 choice should be done in name resolution.
Error handling of failed name is improved too, a ZMQException is used.
Trying to cover many more test case in TCP name resolution.