Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved IPv6 and name resolution handling #680

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

fbacchella
Copy link
Contributor

The actual way to handle IPv6 connectiont could be improved, a lot of code
had no effect. All the IPv6/IPv4 choice should be done in name resolution.

Error handling of failed name is improved too, a ZMQException is used.

Trying to cover many more test case in TCP name resolution.

@fbacchella fbacchella force-pushed the ipv6_improved branch 3 times, most recently from 1e2a65e to 6bb0248 Compare February 27, 2019 09:38
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 84.516% when pulling 6bb0248 on fbacchella:ipv6_improved into 7fd082b on zeromq:master.

@coveralls
Copy link

coveralls commented Feb 27, 2019

Coverage Status

Coverage increased (+0.08%) to 84.485% when pulling d80d9cc on fbacchella:ipv6_improved into 7fd082b on zeromq:master.

src/main/java/zmq/Options.java Outdated Show resolved Hide resolved
src/main/java/zmq/io/net/tcp/TcpAddress.java Outdated Show resolved Hide resolved
src/main/java/zmq/io/net/tcp/TcpAddress.java Outdated Show resolved Hide resolved
src/main/java/zmq/io/net/tcp/TcpConnecter.java Outdated Show resolved Hide resolved
src/main/java/zmq/io/net/tcp/TcpListener.java Outdated Show resolved Hide resolved
The actual way to handle IPv6 connectiont could be improved, a lot of code
had no effect. All the IPv6/IPv4 choice should be done in name resolution.

Error handling of failed name is improved too, a ZMQException is used.

Trying to cover many more test case in TCP name resolution.
Copy link
Contributor

@daveyarwood daveyarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good at this point. Thanks for the PR!

@daveyarwood daveyarwood merged commit 1cfbadb into zeromq:master Feb 27, 2019
@fbacchella fbacchella deleted the ipv6_improved branch March 8, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants