Resolve #776. #777
Merged
Resolve #776. #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there is a checkstyle violation:
|
If a socket failed during close, it's not removed from ZContext, even if it should.
|
The build succeed on my local machin. I'm not sure current failures are coming from this pull request. |
|
It seems to be unrelated, CircleCI was always failing for me. And there is one failing build out of 7 in Travis, where a totally unrelated test was stuck |
|
Agreed - this seems to just be a flaky test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a socket failed during close, it's not removed from ZContext, even
if it should.