Few more code style fixes #3149

sigiesec · 2018-05-31T14:46:05Z

See individual commits

Solution: explicitly compare result against 0

Solution: remove duplicated and redundant code

Solution: add TODO comment regarding handling of the result

Solution: start analysis job first, if enabled, since it takes the longest time

Solution: use a Debug build for analysis

sigiesec added 5 commits May 31, 2018 11:02

Problem: suspicious use of memcmp result

ee4cdf8

Solution: explicitly compare result against 0

Problem: unused values stored to variable, duplicated code

c2ba553

Solution: remove duplicated and redundant code

Problem: unused result of call to pull_msg

4604014

Solution: add TODO comment regarding handling of the result

Problem: analysis job prolongs overall build

3cb4754

Solution: start analysis job first, if enabled, since it takes the longest time

Problem: unused variable warnings for values only used in asserts

67b602f

Solution: use a Debug build for analysis

bluca merged commit 89e5f15 into zeromq:master May 31, 2018

Provide feedback