An alternative approach to threads naming

[opensource-kymetacorp]

Pull Request Notice

Before sending a pull request make sure each commit solves one clear, minimal,
plausible problem. Further each commit should have the following format:

Problem: X is broken

Solution: do Y and Z to fix X

Please try to have the code changes conform to our coding style. For your
convenience, you can install clang-format (at least version 5.0) and then
run make clang-format-check. Don't fix existing issues, if any - just
make sure your changes are compliant. make clang-format-diff will
automatically apply the required changes.
To set a specific clang-format binary with autotools, you can for example
run: ./configure CLANG_FORMAT=clang-format-5.0

Please avoid sending a pull request with recursive merge nodes, as they
are impossible to fix once merged. Please rebase your branch on
zeromq/libzmq master instead of merging it.

git remote add upstream git@github.com:zeromq/libzmq.git
git fetch upstream
git rebase upstream/master
git push -f

In case you already merged instead of rebasing you can drop the merge commit.

git rebase -i HEAD~10

Now, find your merge commit and mark it as drop and save. Finally rebase!

If you are a new contributor please have a look at our contributing guidelines:
CONTRIBUTING

FIRST TIME CONTRIBUTORS PLEASE NOTE

Please add an additional commit with a relicensing grant.

Example

More information on RELICENSING effort

[opensource-kymetacorp]

An alternative approach to threads naming.
Allows to set thread name in the "start" method.
Threads started through the context have a default name even if name wasn't explicitly specified.
Gives epoll the ability to name its thread.
io_thread and reaper name their threads automatically.

[bluca]

Thanks for the PR. pthread_set_name_np, as the name says, it's not part of posix so this will break all platforms other than Linux. There's already a method to set the thread name in a platform compatible way that can be used

[bluca]

I think this will break the existing ZMQ_THREAD_NAME_PREFIX API, as it overwrites the name, won't it?

[bluca]

I'll fix those after merging in #3411

[opensource-kymetacorp]

Luca Thanks. We are aware that an OS independent solution for this issue has been implemented upstream from the version Kymeta is using. This patch was submitted as an alternative approach to the issue. Kymeta Client Software From: Luca Boccassi <notifications@github.com> Sent: Sunday, February 17, 2019 12:17 PM To: zeromq/libzmq <libzmq@noreply.github.com> Cc: OpenSource <opensource@kymetacorp.com>; Author <author@noreply.github.com> Subject: Re: [zeromq/libzmq] An alternative approach to threads naming (#3375) I'll fix those after merging in #3411<#3411> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#3375 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ArIx-xvf_-S9J5HjnWc8FLBRBBv3dcPTks5vObjGgaJpZM4aaJ60>.

[bluca]

I have adapted and fixed up your patch via #3411 so it now works everywhere