Problem: zmq_ctx_get API broken #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: restore EINVAL as errno on unknown option. Broken by zeromq#3642 which started to return EFAULT instead
sigiesec
reviewed
Sep 11, 2020
| @@ -283,6 +283,14 @@ void test_ctx_option_blocky () | |||
| test_context_socket_close (router); | |||
| } | |||
|
|
|||
| void test_ctx_option_invalid () | |||
| { | |||
| TEST_ASSERT_EQUAL_INT (-1, zmq_ctx_set (get_test_context (), -1, 0)); | |||
There was a problem hiding this comment.
Just for the future: You can simply write:
TEST_ASSERT_FAILURE_ERRNO (EINVAL, zmq_ctx_set (get_test_context (), -1, 0));
instead of the two separate assertions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: restore EINVAL as errno on unknown option.
Broken by #3642 which started to
return EFAULT instead