Copied patch from Pawel Subocz to add poll support to zmq.green. #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| select.select(rlist, wlist, xlist) | ||
| except select.error, ex: | ||
| raise zmq.ZMQError(*ex.args) |
There was a problem hiding this comment.
Is there any reason to wrap this in a ZMQError, when it isn't one? Also, I don't think this will even work, because the signatures probably don't match. I would just let any error here raise.
There was a problem hiding this comment.
Hmm good point, removed.
…s. Mixed in existing poll tests in a green fashion.
| s = gevent.spawn(lambda: s1.send(b'msg1')) | ||
| r.join() | ||
| toc = time.time() | ||
| self.assertTrue(toc-tic < 1) |
There was a problem hiding this comment.
This test isn't right. Since you registered s1 with POLLOUT, poller.poll() will always return immediately as s1 can always send. This should only test should only register s2.
|
Looks good, merging. Thanks! |
minrk
added a commit
that referenced
this pull request
Jun 18, 2012
Copied patch from Pawel Subocz to add poll support to zmq.green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2, sorry about the dup PR, my git fu is still weak.