add threadsafe switch to ZMQStream #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
send/getsockopt_stream, and a s/stream/self in on_send_stream
wraps any calls to io_loop API in add_callback, which is the only thread safe method on the IOLoop object. This can introduce delays in the events for code under heavy load, but they should have minimal effect, as the same delays would affect the handling of the events in the same way they affect the registration thereof. Off by default, so existing code will see no changes.
Closed
minrk
added a commit
that referenced
this pull request
Aug 8, 2012
add threadsafe switch to ZMQStream wraps any calls to io_loop API in add_callback, which is the only thread safe method on the IOLoop object. This can introduce delays in the events for code under heavy load, but they should have minimal effect, as the same delays would affect the handling of the events in the same way they affect the registration thereof. Off by default, so existing code will see no changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wraps any calls to io_loop API in add_callback, which is the only thread safe
method on the IOLoop object. This can introduce delays in the events for
code under heavy load, but they should have minimal effect, as the same
delays would affect the handling of the events in the same way they affect
the registration thereof.
Off by default, so existing code will see no changes.
closes #236