Make setup test for "sys/un.h" cross-compile-friendly. #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous test used compile_and_run but running the test binary on the build host is not always possible, for instance when cross-compiling. Furthermore it's not necessary in this case since a missing "sys/un.h" header would be caught at compile time and the lack of library support at link time. Therefore this patch replaces compile_and_run with compile_and_forget which builds the test program but doesn't run it. compile_and_run is removed since it's now unused.
minrk
reviewed
Feb 2, 2017
| if not os.path.exists(basedir): | ||
| os.makedirs(basedir) | ||
| cfile = pjoin(basedir, os.path.basename(src)) | ||
| shutil.copy(src, cfile) | ||
| try: | ||
| cc = get_compiler(compiler, **compiler_attrs) | ||
| efile = test_compilation(cfile, compiler=cc) | ||
| patch_lib_paths(efile, cc.library_dirs) |
There was a problem hiding this comment.
If these are a problem for cross-compiling, they should only be skipped when cross compiling. Under normal circumstances, these steps should still run.
There was a problem hiding this comment.
They're never needed though: you don't need to run the code to test for "sys/un.h", it's purely a compile thing.
IIRC previously compile_and_run was used to detect the ZMQ library version, but now detect_zmq calls test_compilation directly. I think this code is simply a leftover from that time, it was never needed for the sys/un test.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous test used compile_and_run but running the test binary on
the build host is not always possible, for instance when
cross-compiling. Furthermore it's not necessary in this case since a
missing "sys/un.h" header would be caught at compile time and the lack
of library support at link time.
Therefore this patch replaces compile_and_run with compile_and_forget
which builds the test program but doesn't run it. compile_and_run is
removed since it's now unused.