Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update node-addon-api, node-gyp, and node #588

Merged
merged 29 commits into from
Nov 16, 2023

Conversation

pshenmic
Copy link
Contributor

@pshenmic pshenmic commented Nov 16, 2023

Issue

#554 was merged recently which finally fixes zeromq.js v6 in the Node.js LTS (v20) environment, however the CI prebuilds are not working and pipelines getting failed. That's because dependency tree and CI environment is outdated for a recent Node.js v20. This PR updates zeromq.js's dependencies and CI environment to meet latest requirements.

There are still a lot of tests that needs to be fixed though, which I did not try to do.

Successful prebuilds action can be seen here: https://github.com/pshenmic/zeromq.js/actions/runs/689396918

Things done

  • Added node-gyp 10.0.1 override (fixes deprecated distutils)
  • Upgraded CI Node.js version to v20
  • Upgraded PNPM to 8
  • Upgraded MacOS runner to 13 Ventura (fixes macOS prebuilds)
  • Upgraded node-addon-api (fixes windows prebuilds fix)
  • Upgraded deasync (fixes windows prebuilds fix)
  • Removed CI PNPM caching

Copy link
Member

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included the prebuilds in the previous release. What do you mean by those not being included?
https://www.npmjs.com/package/zeromq/v/6.0.0-beta.18?activeTab=code

Copy link
Member

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The changes look good to me. Just left a question on the PR description.

@pshenmic
Copy link
Contributor Author

@aminya
Oh, my bad! Feel like I messed it up by checking in the source code tarball available in the release assets, I should have checked in an npm instead. That's wonderful, just updated the description, thanks for the quick response!

@aminya aminya changed the title fix(ci): make prebuilds buildable again in the CI fix(ci): update node-addon-api, node-gyp, and node Nov 16, 2023
@aminya aminya changed the title fix(ci): update node-addon-api, node-gyp, and node fix: update node-addon-api, node-gyp, and node Nov 16, 2023
@aminya aminya merged commit 2d9d47f into zeromq:master Nov 16, 2023
1 of 6 checks passed
@aminya
Copy link
Member

aminya commented Nov 16, 2023

No worries. Thanks for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants