-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smoke test #634
base: master
Are you sure you want to change the base?
smoke test #634
Changes from 25 commits
4d03aa1
f08439c
ef56cd4
115956b
ef79054
d710f17
fb6bdac
1bd33df
0e94911
7fb3fa1
502ca13
dffc167
c4b57e4
e3688f5
31b55c6
4a6609e
406425d
4abbf21
a341004
bc84d03
542571a
760e64d
46c8953
74e3b81
04fbc78
8bea746
26c2cd2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -180,3 +180,51 @@ jobs: | |
name: prebuilds | ||
pattern: prebuilds-* | ||
delete-merged: true | ||
smoke-test: | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: | ||
- ubuntu-latest | ||
- windows-latest | ||
- macos-latest | ||
pm: | ||
- npm | ||
- yarn | ||
- pnpm | ||
steps: | ||
- uses: actions/setup-node@v4 | ||
- run: | | ||
npm init --init-module testproject -y | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can use this template package and add an example test to it |
||
npm pkg set dependencies.zeromq/"${{ github.repositoryUrl }}#refs/${{ github.ref }}" | ||
|
||
- if: ${{ matrix.pm == 'npm' }} | ||
run: | | ||
npm install | ||
env: | ||
NPM_CONFIG_LOGLEVEL: verbose | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be great to run a simple example where zeromq is imported. This will ensure the runtime compatibility via the smoke test for different Nodejs versions. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was thinking of possibly co-opting https://github.com/zeromq/zeromq.js/blob/ea5f35ceef48a9847562d53f839b3ffb74956711/examples/package.json |
||
- if: ${{ matrix.pm == 'pnpm' }} | ||
run: | | ||
npm install -g pnpm | ||
pnpm install | ||
env: | ||
NPM_CONFIG_LOGLEVEL: verbose | ||
|
||
- if: ${{ matrix.pm == 'yarn' }} | ||
run: | | ||
npm install -g yarn | ||
yarn set version stable | ||
yarn install | ||
env: | ||
YARN_ENABLE_IMMUTABLE_INSTALLS: false | ||
YARN_ENABLE_INLINE_BUILDS: true | ||
- uses: actions/upload-artifact@v4 | ||
if: ${{ failure() && runner.os == 'Windows' }} | ||
with: | ||
name: logs-${{matrix.pm}}-${{runner.os}} | ||
overwrite: true | ||
path: | | ||
C:\npm\cache\_logs\ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can include multiple versions such as
10, 12, 18, 22
to ensure compatibility across different versions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're absolutely right and I'd like to get there before this is merged. As you can see from my embarrassing commit history, I'm not quite there yet...