-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all the optional things available through a builder parameter. #31
Comments
A more generic solution: ZipUtil.create(File).charset(Charset).preserveTimestamp(true).addEntry(ZipEntrySource).addEntries(ZipEntrySource...).addDirectory(File).addArchive(File).execute() addDirectory() and addArchive() should optionally take additional charset to override the output one. |
shelajev
added a commit
that referenced
this issue
Jun 23, 2013
shelajev
referenced
this issue
Jun 23, 2013
shelajev
added a commit
that referenced
this issue
Jun 23, 2013
shelajev
added a commit
that referenced
this issue
Jun 23, 2013
Added many comments to the commits. |
ghost
assigned shelajev
Jul 19, 2013
shelajev
added a commit
that referenced
this issue
Aug 12, 2013
1. Rename instantiation methods: process(file) -> get(file) get() -> create() Now to create Zips instance you either get it from a file or create it. 2. Methods that return Charset aware ZipOutputStream and ZipFile throw IllegalStateException instead of IllegalArgumentException
shelajev
added a commit
that referenced
this issue
Aug 12, 2013
Closing this issue, as other comments that @reinra left are worth having their own issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have a number of optional features that are wanted to include/exclude:
I would even go further and implemented a destination archive (#17) through a parameters map.
Would be cool to simplify an api to somehting like:
Then by default all simple methods would be inplace and with no parametrization, however we won't need to pollute the API with all the variations of charsets, timestamps, existense/lack of destination). Methods would be simpler.
What do you think? Other features that we want to add later could be added there as well, so we won't need to change public api there.
The text was updated successfully, but these errors were encountered: