fix RestController 500 errors #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This problem exists in both the RestController and the ApiController. *Controller.load_config was returning too early if the cluster_config was retrieved from memcached. Later in the controller call chain, if cluster_config is set, config_path is expected to be set as well, but the load_config call was returning prematurely before config_path could be set. This was resulting in intermittent generic 500 errors when exercising the /api/ URL REST features. (Basically, a reqest would work the first time, then throw errors until the cache expires--about 60 seconds later--and then start working again.) This patch fixes it by properly initializing config_path at all times We also verify it by adding a variation of an exsiting test that tests the behavior in memecache presence
|
addresses #151 |
| @@ -1684,6 +1684,7 @@ def HEAD(self, req): | |||
| return HTTPNotImplemented(request=req) | |||
|
|
|||
| def load_config(self, req, config_path): | |||
| self.config_path = config_path | |||
There was a problem hiding this comment.
Why are we not caching both config_path and cluster_config as we are in the ApiController?
|
Because in RestController config_path is taken verbatim from request url and not calculated through container metadata (and accessing container metadata could be expensive). |
|
Alright, cool. Looks good! |
larsbutler
added a commit
that referenced
this pull request
Sep 10, 2014
fix RestController 500 errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem exists in both the RestController and the ApiController.
*Controller.load_config was returning too early if the
cluster_config was retrieved from memcached. Later in the
controller call chain, if cluster_config is set, config_path is
expected to be set as well, but the load_config call was returning
prematurely before config_path could be set.
This was resulting in intermittent generic 500 errors when exercising
the /api/ URL REST features. (Basically, a reqest would work the first
time, then throw errors until the cache expires--about 60 seconds
later--and then start working again.)
This patch fixes it by properly initializing config_path at all times
We also verify it by adding a variation of an exsiting test that tests the behavior in memecache presence