Loosen jinja versions requirements - fixes #41

[AvnerCohen]

No description provided.

[AvnerCohen]

@zerwes Any chance this can be merged ? this is blocking us from using the lib and I would like to avoid forking just for this simple change.

[zerwes]

thank you for the fix

[AvnerCohen]

Thanks @zerwes !! Can this please be pushed to pypi ?

[AvnerCohen]

@zerwes Maybe less busy time ? any chance this can be pushed to pypi ?

[zerwes]

@AvnerCohen ... Sorry, not much time spare (children, wife, house, job ... the full catastrophe), but I tried to make release 0.4.17 with your PR ...
But I get some errors w/ Jinja2-3.0.2 running make testinstallvirtualenv using
installrequires = ['PyYAML<6', 'Jinja2>1,<4', 'MarkupSafe<2'] (for python 2.7) ...

Installed /tmp/hiyapyco/python2.7/lib/python2.7/site-packages/MarkupSafe-1.1.1-py2.7-linux-x86_64.egg
Searching for Jinja2<4,>1
Reading https://pypi.org/simple/Jinja2/
Downloading https://files.pythonhosted.org/packages/f8/86/7c0eb6e8b05385d1ce682abc0f994abd1668e148fb52603fa86e15d4c110/Jinja2-3.0.2.tar.gz#sha256=827a0e32839ab1600d4eb1c4c33ec5a8edfbc5cb42dafa13b81f182f97784b45
Best match: Jinja2 3.0.2
Processing Jinja2-3.0.2.tar.gz
Writing /tmp/easy_install-MVCRe3/Jinja2-3.0.2/setup.cfg
Running Jinja2-3.0.2/setup.py -q bdist_egg --dist-dir /tmp/easy_install-MVCRe3/Jinja2-3.0.2/egg-dist-tmp-TiyKgj
Traceback (most recent call last):
  File "setup.py", line 42, in <module>
    platforms = 'any',
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/__init__.py", line 162, in setup
    return distutils.core.setup(**attrs)
  File "/usr/lib/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/usr/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/command/install.py", line 67, in run
    self.do_egg_install()
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/command/install.py", line 117, in do_egg_install
    cmd.run(show_deprecation=False)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 449, in run
    self.easy_install(spec, not self.no_deps)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 691, in easy_install
    return self.install_item(None, spec, tmpdir, deps, True)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 738, in install_item
    self.process_distribution(spec, dist, deps)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 783, in process_distribution
    [requirement], self.local_index, self.easy_install
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/pkg_resources/__init__.py", line 782, in resolve
    replace_conflicting=replace_conflicting
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1065, in best_match
    return self.obtain(req, installer)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1077, in obtain
    return installer(requirement)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 710, in easy_install
    return self.install_item(spec, dist.location, tmpdir, deps)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 736, in install_item
    dists = self.install_eggs(spec, download, tmpdir)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 921, in install_eggs
    return self.build_and_install(setup_script, setup_base)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 1189, in build_and_install
    self.run_setup(setup_script, setup_base, args)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 1175, in run_setup
    run_setup(setup_script, args)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/sandbox.py", line 253, in run_setup
    raise
  File "/usr/lib/python2.7/contextlib.py", line 35, in __exit__
    self.gen.throw(type, value, traceback)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/sandbox.py", line 195, in setup_context
    yield
  File "/usr/lib/python2.7/contextlib.py", line 35, in __exit__
    self.gen.throw(type, value, traceback)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/sandbox.py", line 166, in save_modules
    saved_exc.resume()
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/sandbox.py", line 141, in resume
    six.reraise(type, exc, self._tb)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/sandbox.py", line 154, in save_modules
    yield saved
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/sandbox.py", line 195, in setup_context
    yield
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/sandbox.py", line 250, in run_setup
    _execfile(setup_script, ns)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/sandbox.py", line 45, in _execfile
    exec(code, globals, locals)
  File "/tmp/easy_install-MVCRe3/Jinja2-3.0.2/setup.py", line 7, in <module>
    
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/__init__.py", line 162, in setup
    return distutils.core.setup(**attrs)
  File "/usr/lib/python2.7/distutils/core.py", line 124, in setup
    dist.parse_config_files()
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/_virtualenv.py", line 21, in parse_config_files
    result = old_parse_config_files(self, *args, **kwargs)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/dist.py", line 702, in parse_config_files
    ignore_option_errors=ignore_option_errors)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/config.py", line 121, in parse_configuration
    meta.parse()
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/config.py", line 426, in parse
    section_parser_method(section_options)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/config.py", line 399, in parse_section
    self[name] = value
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/config.py", line 184, in __setitem__
    value = parser(value)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/config.py", line 515, in _parse_version
    version = self._parse_attr(value, self.package_dir)
  File "/tmp/hiyapyco/python2.7/lib/python2.7/site-packages/setuptools/config.py", line 349, in _parse_attr
    module = import_module(module_name)
  File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/tmp/easy_install-MVCRe3/Jinja2-3.0.2/src/jinja2/__init__.py", line 5, in <module>
  File "/tmp/easy_install-MVCRe3/Jinja2-3.0.2/src/jinja2/bccache.py", line 26
    def get(self, key: str) -> bytes:
                     ^
SyntaxError: invalid syntax

python 2.7 is dead, long live python 2.7 ... :)
I think from version 0.5 on I will quit python 2.7 support, but I would give this step a little bit more time ...
Untill then I will try to fix the installrequires using https://www.python.org/dev/peps/pep-0508/#environment-markers
So please be patient for a few days ... I'll try to make the release

[AvnerCohen]

Thanks @zerwes Totally understand life and so.

If this is the case, I would actually suggest to drop python 2.7 support and publish this PR both together as part of 0.5

This way there will be no need to spend any time on solving this for a minor patch on 0.4x.

[look4regev]

@zerwes ping please :)
Can we follow @AvnerCohen 's suggestion so we can have a new version in pypi?