Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement custom bitflags #21

Merged
merged 12 commits into from
Sep 17, 2021
Merged

Implement custom bitflags #21

merged 12 commits into from
Sep 17, 2021

Conversation

zeskeertwee
Copy link
Owner

No description provided.

@zeskeertwee zeskeertwee self-assigned this Sep 16, 2021
@zeskeertwee zeskeertwee added vach This issue is related to the vach crate WIP Work-In-Progress labels Sep 16, 2021
@zeskeertwee zeskeertwee marked this pull request as draft September 16, 2021 13:33
@zeskeertwee
Copy link
Owner Author

TODO: tests dont pass yet

@sokorototo
Copy link
Collaborator

FIX: I fixed the bugs I found, and I refactored the code somehow. I still need you to pass through what I have done. @zeskeertwee

@sokorototo sokorototo marked this pull request as ready for review September 17, 2021 18:37
@sokorototo sokorototo merged commit 35bd162 into main Sep 17, 2021
@sokorototo sokorototo deleted the bitflags-implementation branch September 17, 2021 19:08
@zeskeertwee zeskeertwee added enhancement New feature or request and removed WIP Work-In-Progress labels Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokorototo sokorototo sokorototo approved these changes

Assignees

@zeskeertwee zeskeertwee

Labels
enhancement New feature or request vach This issue is related to the vach crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeskeertwee @sokorototo