I did many, many changes. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokorototo
added
enhancement
zeskeertwee
requested changes
Oct 5, 2021
vach/src/loader/archive.rs
Outdated
| // If there is an error the data is flagged as invalid | ||
| if entry.signature.is_some() { | ||
| if let Err(info) = pub_key.verify_strict(&buffer, &entry.signature.unwrap()) { | ||
| eprintln!("{}", &info); |
There was a problem hiding this comment.
we should probably not print to stdout, if we really want to print something we should use log, so that the user can filter it out if they want to.
There was a problem hiding this comment.
Or just use regullar Err structs
vach/src/lib.rs
Outdated
| @@ -15,7 +15,7 @@ pub(crate) mod writer; | |||
| pub use rand; | |||
|
|
|||
| /// Current file spec version, both `Loader` and `Builder` | |||
| pub const VERSION: u16 = 13; | |||
| pub const VERSION: u16 = 15; | |||
There was a problem hiding this comment.
if the crate's version is now 0.1.6, shouldn't this be 16?
zeskeertwee
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
Builderis more memory efficient at the cost that its generic type s now includeio::Seek. The spec has changed, so the crate version changes. Now the space covered by signatures can be used for leaf data if the Archive does not use signatures. If you flip thehas_signaturesbit, you corrupt the data and the loader flags any data from the archive as insecure. Many more incremental changes