Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First commit for vach 0.3.0 #53

Merged
merged 46 commits into from
Dec 29, 2021
Merged

First commit for vach 0.3.0 #53

merged 46 commits into from
Dec 29, 2021

Conversation

sokorototo
Copy link
Collaborator

With this commit comes

  • Builder callbacks now just take a closure, instead of a Boxed closure
  • The size of flags has been increased from u16 to u32
  • Support for two new compression algorithms: brotli and snappy.
  • Compression is handled by a single struct, like encryption, making small changes now easier.

sokorototo and others added 30 commits November 24, 2021 20:17
@sokorototo
cargo fmt
5bd2ebd
@sokorototo
doc update
1d3f72b
@sokorototo
More verbose and rusty description
0422d94
@sokorototo
Changed how flags are formatted in debug mode
27c6da3
@sokorototo
rust shorthand syntax to reduce repetitive code
46fcb4f
@sokorototo
_
1966b5f
@sokorototo
For better testing
aaf36c3
@sokorototo
Changed visibility of leafs field in builder
742deb1
@sokorototo
_
1acfa57
@sokorototo
Usage for the CLI
487f88b
@sokorototo
_
bc4c39e
@sokorototo
_
aed4be8
@sokorototo
_doc change_
9bca03f
@sokorototo
Handles empty call to the CLI
e80135c
@sokorototo
IMplicit logging and error management
f71a2e2
@sokorototo
Improving my imaginary reddit bot script
2dae538
@sokorototo
Merge branch 'zeskeertwee:main' into main
f162879
@sokorototo
Further improvements fto my imaginary bot script
d43e383
@sokorototo
Bumped up rust edition
9c39998
@sokorototo
Better input parsing
ca3a456
@sokorototo
_
2749597
@sokorototo
existing function for what you were trying to do
ff7b8f1
@sokorototo
bugfixes
778ce65
@sokorototo
_
4024395
@sokorototo
bump up dat version
9d01723
@sokorototo
&str allows more types to be dereferenced
5cabe94
@sokorototo
Removes an extra deref step
c2f6643
@sokorototo
Tests for small data
0e83a94
@sokorototo
_
be7a5e7
@sokorototo
Preparing the CLI for publishing
7a5a3fc
zeskeertwee
zeskeertwee requested changes Dec 29, 2021
View reviewed changes
spec/main.txt
ARCHIVE_VERSION: [u8;2] | u16
CAPACITY: [u8;2] | u16

FLAGS: [u8;2] | u16, SPECIFIES;
FLAGS: [u8;4] | u32, SPECIFIES;
1 => HAS_SIGNATURES
2-15 => CUSTOM_DATA
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably annotate what the other 16 bits are for

spec/main.txt Outdated
1 => HAS_SIGNATURES
2-15 => CUSTOM_DATA

>---- REGISTRY ----<
ENTRIES: (x) * HEADER::CAPACITY
FLAGS: [u8;2] | u16, SPECIFIES;
FLAGS: [u8;4] | u32, SPECIFIES;
0 => IS_COMPRESSED
1-3 => RESERVED
4-15 => CUSTOM_DATA
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here

@zeskeertwee zeskeertwee merged commit a14357b into zeskeertwee:main Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeskeertwee zeskeertwee zeskeertwee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokorototo @zeskeertwee