This repository has been archived by the owner on Feb 15, 2021. It is now read-only.
Adding initial migration #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 95.16% 95.38% +0.22%
==========================================
Files 4 5 +1
Lines 124 130 +6
==========================================
+ Hits 118 124 +6
Misses 6 6
Continue to review full report at Codecov.
|
|
@gustavi this issue has been staying like this for a while. I was wondering wether you will have time to take a look at it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s) : #16
This is just adding the migration so everything should work fine.
As the model is not used by default another (maybe even better) approach is to turn the model into abstract one. This way if users want to use that functionality they will have create their own model that inherits from this one, but the app won't contain any migrations. This however might lead to compatibility issues so I wouldn't recommend it for minor versions change.