fix(paginator): #2556 Fixes paging page with previous item in list. #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,11 +40,12 @@ def get_context_data(self, **kwargs): | |||
| context.update(kwargs) | |||
| return super(MultipleObjectMixin, self).get_context_data(**context) | |||
|
|
|||
| def build_list(self): | |||
| def build_list_with_previous_item(self, queryset): | |||
There was a problem hiding this comment.
Y'a pas de risques d'effets de bord hors des MP avec ceci ?
There was a problem hiding this comment.
ZdSPagingListView est utilisé uniquement dans les vues CVB (donc dans les vues refactorées) et la liste des messages d'un MP est la première à devoir récupérer le dernier message de la page précédente. La méthode (définie dans ZdSPagingListView) est donc utilisée nulle part ailleurs.
|
QA : OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrige la pagination avec l'item précédent dans la liste. Cette correction est visible dans la liste des MPs (sans item précédent) et dans la liste des messages d'un MP (avec un item précédent).
Corrige #2556 et #2557 par effet de bord (positif).
QA :