Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo suggestions de recherche #3292

Merged
merged 2 commits into from Jan 12, 2016

Conversation

@Vayel
Copy link
Contributor

commented Jan 12, 2016

Q R
Correction de bugs ? non
Nouvelle Fonctionnalité ? non
Tickets (issues) concernés Aucun

@Vayel Vayel changed the title Typo Typo suggestions de recherche Jan 12, 2016

@@ -45,7 +45,7 @@ def home(request):

try:
with open(os.path.join(BASE_DIR, 'suggestions.txt'), 'r') as suggestions_file:
suggestions = ', '.join(random.sample(suggestions_file.readlines(), 5)) + ', ...'
suggestions = ', '.join(random.sample(suggestions_file.readlines(), 5)) + '...'

This comment has been minimized.

Copy link
@Emeric54

Emeric54 Jan 12, 2016

Member

J'étais pourtant persuadé que c'était bien comme ça. Mais n'étant pas expert de ces règles...

@@ -45,7 +45,7 @@ def home(request):

try:
with open(os.path.join(BASE_DIR, 'suggestions.txt'), 'r') as suggestions_file:
suggestions = ', '.join(random.sample(suggestions_file.readlines(), 5)) + ', ...'
suggestions = ', '.join(random.sample(suggestions_file.readlines(), 5)) + '...'
except IOError:
suggestions = 'Mathématiques, UDK, HTML, Java, Python'

This comment has been minimized.

Copy link
@Emeric54

Emeric54 Jan 12, 2016

Member

Du coup, on peut en profiter pour rajouter les « ... » ici tant que l'on y est ? Bon, c'est vraiment des détails...

This comment has been minimized.

Copy link
@Vayel

Vayel Jan 12, 2016

Author Contributor

J'en ai profité pour diversifier les suggestions par défaut, qu'on ne se croie pas sur un site d'informatique.

This comment has been minimized.

Copy link
@Emeric54

Emeric54 Jan 12, 2016

Member

Super ! J'avais laissé les anciennes suggestions. Il y a très peu de chance que l'on tombe sur ces suggestions, mais sait-on jamais.

except IOError:
suggestions = 'Mathématiques, UDK, HTML, Java, Python'
suggestions = 'Mathématiques, Droit, UDK, Langues, Python...'

This comment has been minimized.

Copy link
@GerardPaligot

GerardPaligot Jan 12, 2016

Member

Pourquoi il n'y a pas Android dans la liste par défaut ? :o

This comment has been minimized.

Copy link
@Vayel

Vayel Jan 12, 2016

Author Contributor

Hum... comment dire ? :D

@SpaceFox

This comment has been minimized.

Copy link
Member

commented Jan 12, 2016

Hop, je merge, merci !

SpaceFox added a commit that referenced this pull request Jan 12, 2016

@SpaceFox SpaceFox merged commit 83751fe into zestedesavoir:dev Jan 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SpaceFox SpaceFox added this to the Version de développement milestone Jan 12, 2016

@Vayel Vayel deleted the Vayel:typo-suggestions-recherche branch Jan 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.