Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3570 : corrige l'utilisation de debug_toolbar en prod #3580

Merged
merged 1 commit into from
Jun 16, 2016
Merged

Fix #3570 : corrige l'utilisation de debug_toolbar en prod #3580

merged 1 commit into from
Jun 16, 2016

Conversation

gustavi
Copy link
Contributor

@gustavi gustavi commented May 3, 2016

Q R
Type de modification correction de bug
Ticket(s) (issue(s)) concerné(s) #3570

QA

  • Si la django_debug_toolbar est installé", désinstallez-la avec pip uninstall django_debug_toolbar
  • Créer un fichier settings_prod.py qui contient DEBUG = False et ALLOWED_HOSTS = ['127.0.0.1', 'localhost']
  • Vérifier que le site est utilisable (par d'erreur liée à la django_debug_toolbar)

Note : le design et les médias ne sont pas gérés automatiquement en DEBUG = False ce qui explique que le design est "cassé".

@coveralls
Copy link

coveralls commented May 3, 2016

Coverage Status

Coverage remained the same at 87.494% when pulling fdea7ef on gustavi:fix-3570 into bbd193f on zestedesavoir:dev.

@firm1
Copy link
Contributor

firm1 commented May 3, 2016

@artragis je crois que tu n'as pas compris le problème que résoud cette PR.
relis bien l'issue.

Le mar. 3 mai 2016 12:49, artragis notifications@github.com a écrit :

Je refuse cette PR.

On a le settings_prod pour enlever le debug donc osef total de la toolbar.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#3580 (comment)

@artragis
Copy link
Member

artragis commented May 3, 2016

D'où l'idée du message supprimé. J'avais juste mal lu le code.

2016-05-03 12:55 GMT+02:00 firm1 notifications@github.com:

@artragis je crois que tu n'as pas compris le problème que résoud cette PR.
relis bien l'issue.

Le mar. 3 mai 2016 12:49, artragis notifications@github.com a écrit :

Je refuse cette PR.

On a le settings_prod pour enlever le debug donc osef total de la
toolbar.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
<
#3580 (comment)


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#3580 (comment)

@gustavi
Copy link
Contributor Author

gustavi commented May 10, 2016

Petit UP :)

@gustavi
Copy link
Contributor Author

gustavi commented Jun 16, 2016

UP QA

@artragis
Copy link
Member

Oups j'avais oublié de dire OK ici.

2016-06-16 15:46 GMT+02:00 Laville Augustin notifications@github.com:

UP QA


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3580 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABc_xUVLOSyGOYg2VBU5J9CdvnTL-Q04ks5qMVPJgaJpZM4IV8id
.

@GerardPaligot GerardPaligot merged commit e463dc1 into zestedesavoir:dev Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants