Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] Evite les notifications persistantes à la suppression d'un MP. #3657

Closed
wants to merge 4 commits into from
Closed

[Hotfix] Evite les notifications persistantes à la suppression d'un MP. #3657

wants to merge 4 commits into from

Conversation

GerardPaligot
Copy link
Member

@GerardPaligot GerardPaligot commented Jun 10, 2016 •
edited

Q R
Type de modification correction de bug
Ticket(s) (issue(s)) concerné(s) #3639

QA

  • Placez-vous sur la version 18.1.
  • Créez un MP entre 2 membres et supprimer les 2 membres de la conversation privée sans lire le MP.
  • Constatez que vous avez une notification qui pointe vers une 404.
  • Placez-vous sur la branche de cette PR.
  • Lancez la commande python manage.py delete_useless_notif
  • Constatez que la notification n'est plus là.
  • Refaite la création et suppression d'un MP entre 2 membres.
  • Constatez qu'il n'y a plus aucune notification.

@coveralls
Copy link

coveralls commented Jun 10, 2016 •
edited

Coverage Status

Coverage decreased (-0.08%) to 87.317% when pulling 202e519 on GerardPaligot:fix_3639 into 99f8641 on zestedesavoir:release-v18.

@artragis
Copy link
Member

Tu peux changer le titre pour faire apparaître que c'est un hotfix? Car là j'ai un peu de mal à voir quelles PR sont prioritaires ou pas.

artragis
artragis reviewed Jun 12, 2016
View reviewed changes
zds/utils/api/serializers.py
@@ -13,10 +13,14 @@ class Meta:
fields = ('count', 'users')


class DislikesSerializer(LikesSerializer):
class DislikesSerializer(ModelSerializer):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi donc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ca vient pas de chez moi mais des commits de @gustavi.

@GerardPaligot GerardPaligot changed the title Evite les notifications persistantes à la suppression d'un MP. [Hotfix] Evite les notifications persistantes à la suppression d'un MP. Jun 12, 2016
@GerardPaligot
Copy link
Member Author

#3663

@GerardPaligot GerardPaligot deleted the fix_3639 branch June 13, 2016 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GerardPaligot @coveralls @artragis @gustavi