Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sentry 812 #4316

Merged
merged 5 commits into from
Apr 26, 2017
Merged

Fix sentry 812 #4316

merged 5 commits into from
Apr 26, 2017

Conversation

artragis
Copy link
Member

@artragis artragis commented Apr 21, 2017

Q R
Type de modification correction de bug
Ticket(s) (issue(s)) concerné(s) https://sentry.sandhose.fr/zeste-de-savoir/beta-backend/issues/812/

QA

  • créer un billet avec user1
  • avec user2 souscrivez au billet
  • dépublier le billet de user1
  • pas d'erreur 500

@coveralls
Copy link

coveralls commented Apr 21, 2017

Coverage Status

Coverage remained the same at 88.609% when pulling e120f0b on artragis-patch-1 into e73fd05 on release-v23.

@artragis
Copy link
Member Author

modification : il faut d'abord publier, puis souscrire mais qu'aucun message ne soit envoyé.

@Anto59290
Copy link
Contributor

Ne faudrait-il pas un test de non régression ?

@artragis
Copy link
Member Author

Je vais tenter d'en ajouter un même si le scénario est assez long à exécuter...

@gllmc
Copy link
Member

gllmc commented Apr 26, 2017

Rapport de QA : je n'ai plus d'erreur 500, mais quand je me reconnecte avec user2, j'ai une notification permanente qui donne sur une 404 (testé avec les boutons Dépublier et Dépublier définitivement). :/

@vhf vhf added this to the v23 milestone Apr 26, 2017
@coveralls
Copy link

coveralls commented Apr 26, 2017

Coverage Status

Coverage decreased (-16.2%) to 72.424% when pulling 58feeb9 on artragis-patch-1 into e73fd05 on release-v23.

@coveralls
Copy link

Coverage Status

Coverage decreased (-16.2%) to 72.434% when pulling 4ea20dd on artragis-patch-1 into e73fd05 on release-v23.

@coveralls
Copy link

Coverage Status

Coverage decreased (-16.2%) to 72.434% when pulling 7b5f5bb on artragis-patch-1 into e73fd05 on release-v23.

@coveralls
Copy link

coveralls commented Apr 26, 2017

Coverage Status

Coverage decreased (-16.2%) to 72.434% when pulling de44d40 on artragis-patch-1 into e73fd05 on release-v23.

@coveralls
Copy link

coveralls commented Apr 26, 2017

Coverage Status

Coverage increased (+0.001%) to 88.616% when pulling 2e9b2c4 on artragis-patch-1 into 8f5035f on release-v23.

@coveralls
Copy link

coveralls commented Apr 26, 2017

Coverage Status

Coverage increased (+0.001%) to 88.616% when pulling 92a5255 on artragis-patch-1 into 8f5035f on release-v23.

@gllmc gllmc added C-Back Concerne le back-end Django S-BUG Corrige un problème labels Apr 26, 2017
@gllmc gllmc merged commit 2774b0b into release-v23 Apr 26, 2017
@vhf vhf deleted the artragis-patch-1 branch July 9, 2017 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Back Concerne le back-end Django S-BUG Corrige un problème
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants