Modified zest.releaser to avoid "register" command when not publishing to public PyPi #192
Conversation
…g to public PyPi The private PyPi cloud repositories often don’t use the register command causing publish to fail. Don’t use this command unless you are publishing to the public one.
|
Actually, on the public pypi, separately registering is not needed anymore and will actually fail with current twine. The public pypi is also the only server where we know for sure how to ask if a package is already registered or not. But this is no longer needed, because, as said, registering is not needed. So we need to clean this up. A proposal:
Does that sound sane? It it quite different from the approach in your pull request. Would you be willing to work on this new approach? Otherwise I can see when I have the time. |
|
Yes, that sounds like a good approach. I can probably get to this work later this week or early next week. Or, if you feel like doing it, that's fine too. |
|
Hi, I'm thinking that the URL equivalence check is not necessary if we simply turn off register by default and make it a configuration option. Does that approach sound okay to you? |
1. Changed register action to False by default. 2. Added a config boolean to retrieve the register action override. 3. Refactored the logic to retrieve a boolean value from the config file to reduce code duplication. 4. Simplified the logic in upload_distributions to only call register if the config file sets register to yes.
| return default | ||
| return self.__get_boolean('zest.releaser', 'no-input') | ||
|
|
||
| def __get_boolean(self, section, key): |
There was a problem hiding this comment.
The __get_boolean method should accept a default value. Currently you make the default False. In want_release we want True as default, which is not happening now.
Also, I would rename this to _get_boolean or _getboolean. A double underscore indicates a special method, which is not the case here.
| do_register = False | ||
| question = "Upload" | ||
| if self.pypiconfig.register_package(): | ||
| logger.info("Registering...") |
There was a problem hiding this comment.
If a user has multiple servers in his ~.pypirc, this change means we register at all three servers, without asking any questions.
I would prefer this:
- Ask if user wants to upload to server X.
- No: don't upload and don't register.
- Yes: if register is on in the config, we register. And then we upload.
|
I have added a few remarks in the commit. For the rest it looks good. |
|
This was replaced by your own new pull request #194, right? I will close this one then. |
The private PyPi cloud repositories often don’t use the register
command causing publish to fail. Don’t use this command unless you are
publishing to the public one.