Prevent a crash in case the output of the command is not a valid utf-8 sequence. #211
Conversation
Natim
force-pushed
the
210-prevent-crash-if-command-output-is-not-utf-8
branch
from
3a15b27
to
60846e9
Compare
| try: | ||
| stdout_output = stdout_output.decode(OUTPUT_ENCODING) | ||
| except UnicodeDecodeError: | ||
| stdout_output = '%s stdout output is not a valid %s stream.' % ( |
There was a problem hiding this comment.
So... instead of getting back output from, for instance, "git diff" we now get an error message?
This silences the error: is this always a good thing?
There was a problem hiding this comment.
Another way to handle that would be not to decode the output.
Since we are printing it back we could just keep it as bytes instead so that the terminal would have to handle the display and it would look really close to the original one.
There was a problem hiding this comment.
Is it a good thing to silence the error?
To be honest I don't think we should crash on UnicodeDecodeError then my solution might not be the right one, we should talk about it and see how we want to handle it.
There was a problem hiding this comment.
We could do .decode('utf-8', 'replace').
|
If this is still a problem, please try with latest version 7.0.0a1. Python 3 only, so maybe encoding problems have gone away. |
Fixes #210