Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a keyboard shortcut hook, adding a code drawer open/close shrtcut #842

Merged
merged 16 commits into from
Jul 28, 2021

Conversation

d88naimi
Copy link
Contributor

Adding a keyboard shortcut hook
Adding code drawer open/close shortcut

Screen Shot 2021-07-23 at 1 34 15 PM

Screen Shot 2021-07-23 at 1 34 23 PM

@d88naimi d88naimi marked this pull request as draft July 23, 2021 20:35
@d88naimi d88naimi marked this pull request as ready for review July 26, 2021 14:02
src/shell/hooks/useKeyboardShortcut.js Outdated Show resolved Hide resolved
src/shell/hooks/useKeyboardShortcut.js Outdated Show resolved Hide resolved
src/shell/hooks/useKeyboardShortcut.js Outdated Show resolved Hide resolved
src/apps/content-editor/src/app/views/ItemEdit/ItemEdit.js Outdated Show resolved Hide resolved
src/apps/media/src/app/components/MediaDetailsModal.js Outdated Show resolved Hide resolved
src/shell/hooks/useMetaKey.js Outdated Show resolved Hide resolved
@shrunyan
Copy link
Contributor

shrunyan commented Jul 28, 2021

Please thoroughly test these 2 secarios

  • Does the useEffect logic inside the hook get called, cleaning up the event listener, when the consuming component unmounts?
  • Does consuming the hook twice in the same view, or even the same component, attach to handlers and both callbacks are triggered with the same key press?

@d88naimi d88naimi requested a review from shrunyan July 28, 2021 18:25
@shrunyan shrunyan merged commit 47050da into master Jul 28, 2021
@shrunyan shrunyan deleted the feature/keyboard-shortcut-hook branch July 28, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants