fix(crosschain): use event index in inbound tx digest
#1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
changed the title
crosschain): use event index in inbound tx digest
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Closed
lumtis
requested review from
brewmaster012,
kingpinXD,
kevinssgh,
fadeev and
ws4charlie
as code owners
CharlieMc0
added a commit
that referenced
this pull request
Dec 19, 2023
* feat: zeta supply checks (#1358) * chore: improve changelogs format (#1390) * sort changelogs * refactor format * comment * fix(`crosschain`): use event index in inbound tx digest (#1372) * add event index in observer inbound * rename messages * update method usage * use event index * fix cosmos-gosec * depositor contract * smoketest refactor * fix contracts * mutiple deposits smoke tests * fix depositor * withdrawer contract * fix smoketest deposits * fix withdrawer contract * multiple withdraw test * fix contracts * fix withdraws * update changelog * fix: cherry pick v10.1.x hotfix (minRelayTxFee and bitcoin mainnet/testnet address format) (#1367) * skip some more recent garbage outTx trackers * skip garbage trackers and increase btc gas fee * skip mainnet addresses in cctxs * cherry picked minRelayTxFee hotfix and bitcoin testnet/mainnet address format fix * resolve conflict * update CHANGELOG.md for v10.1.x hotfix --------- Co-authored-by: charliec <charliec@zetachain.com> Co-authored-by: brewmaster012 <88689859+brewmaster012@users.noreply.github.com> * feat: update observer (#1384) * chore: add chain id to localnet and open port 26657 to make local testing easier. (#1401) * added chain id to configs * mapped port 26657 to localhost * feat: Add HSM capability for zetaclient hot key - non production (#1387) * initial commit * Added sign function and unit test * hsm config updates * introduce hsm mode * added commands to get address and generate key in hsm * skipping unit test as it will fail in CI * ran make generate and fixed lint errors * Update cmd/zetaclientd/hsm.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update zetaclient/broadcast.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update zetaclient/broadcast.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update zetaclient/hsm_signer.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update zetaclient/hsm_signer.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update zetaclient/hsm_signer.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * cleanup * added config for hsm hotkey name and moved hsm mode flag to zetabridge cfg * add entry to changelog. * moved hsm to new package and added build flag for unit test * add changelog entry * fix lint errors --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * fix: speed up evm outtx inclusion and improve log prints (#1406) Co-authored-by: charliec <charliec@zetachain.com> * docs: add code freeze note (#1414) * zetaclient: allow one 1 event that remotely calls zEVM contract per tx * revert the accidental last commit * include bitcoin outtx regardless of the cctx status (#38) * refactor: condense logging for a supply checker (#9) * chore: increment handler version (#5) Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * test: add tests for out tx tracker (#10) * add tests fro out ts tracker * use getEthereumChainID function in tests --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * fix: Zellic-3.7 - Add check for existing contract address to avoid overwriting. (#13) * add check for existing contract address to avoid overwriting. * Added check for redeployment of gas and asset token contracts Added unit test for this scenario * update changelog --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * fix: Zellic-3.2 - prevent deposit when zrc20 is paused (#31) * add pause check * revert on paused * update tests * add smoke test check * goimports * changelog * Update x/crosschain/keeper/evm_deposit.go Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> --------- Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> * test: ballot tests (#17) * refactor(`fungible`): use code hash in `MsgUpdateContractBytecode` to allow for rollback (#23) * code hash request * make generate * udpate message * add cli command * udpate smoke tests * changelog * update message name * add check for length * replace log with event * add is contract check * refactor: consolidate builds (#22) * remove begin block * remove build from smoketest * deploy system contracts message * msg tx * add system contract deployment in smoke tests * start core params refactor * changelog * refactor chains * config refactor * remaining build tags * lint issues * lint issues 2 * gen docs * gen docs 2 * gosec issues 1 * fix cosmos nosec * lint issues * fix core params check * make generate * fix assign * use privnet chains by default * fix chain fetching * use local goerli for smoke tests * remove unamed gosec * address nosec * other goerli net to rename in smoketests * gosec * nosec alerts * nosec alert 2 * use Bitcoin specific network * fix address system contracts * add logs in test * Add more logs * test remaining smoke tests * remove hardcoded ZetaChain chain ID * remove bitcoin hardcoded values * add back smoketests * fix smoke test except cross chain swap * make generate * add log message * fix evm swap contract * fix unit test 1 * fix CLI tests * make generate * fix log error * fix Bitcoin proof test * fix address test * remove network flag and improve smoke tests * add admin group * move core params out of genesis * remove unnecessary RemoveInTxTrackerIfExists * add check for contract failure * Update x/crosschain/keeper/keeper_cross_chain_tx_vote_inbound_tx.go Co-authored-by: Tanmay <tanmay@zetachain.com> * fix install in action * improve events for system contract deploy * error handling for bitcoin net params * add utility functions in common * add stateful smoketest from source * try test fix * fix unit test * fix tests --------- Co-authored-by: Tanmay <tanmay@zetachain.com> * refactor: disable zeta supply checker routine (#45) * docs: update changelog with v11.0.0 * chore: update go releaser --------- Co-authored-by: Tanmay <tanmay@zetachain.com> Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> Co-authored-by: charliec <charliec@zetachain.com> Co-authored-by: brewmaster012 <88689859+brewmaster012@users.noreply.github.com> Co-authored-by: Charlie <31941002+CharlieMc0@users.noreply.github.com> Co-authored-by: kevinssgh <79858682+kevinssgh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use event index in inbound tx digest to prevent duplicated CCTX index
Closes:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: