feat: update observer #1384

kingpinXD · 2023-11-07T04:20:13Z

Description

Add a new transction which allows

A tombstones operator to update their operator address
An admin to update someones operator address

Closes:

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

Checklist:

I have added unit tests that prove my fix feature works

github-actions · 2023-11-07T22:00:58Z

!!!WARNING!!!
nosec detected in the following files: x/observer/client/cli/tx_update_observer.go, x/observer/keeper/msg_server_update_observer_test.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

…g-update-observer

lumtis · 2023-11-08T21:51:38Z

@kingpinXD can we add a description in the PR?

lumtis

First review, have to drop off for a call, gonna make another review after

proto/observer/observer.proto

testutil/keeper/observer.go

x/observer/client/cli/tx_update_observer.go

lumtis

We only allow a observer to update their address if they become tombstoned.
Couldn't we allow them to update it under any condition? For example they need to use a new key for a various reason like new security setup

x/observer/keeper/keeper.go

x/observer/keeper/keeper_test.go

x/observer/keeper/keeper_utils.go

x/observer/keeper/msg_server_add_observer.go

x/observer/keeper/msg_server_update_observer.go

x/observer/keeper/msg_server_update_observer_test.go

x/observer/types/message_update_observer.go

kingpinXD · 2023-11-08T23:43:48Z

We only allow a observer to update their address if they become tombstoned. Couldn't we allow them to update it under any condition? For example they need to use a new key for a various reason like new security setup

No, because if we make this TX permission less it could lead to a situation where more than 66 % of observers change their operator address in the same block, which means any ballots created in that block cannot be finalized.
If they change their setup, they must contact the admin to help change their operator .

lumtis

Looks good

Just left two minor comments

proto/observer/observer.proto

x/observer/types/message_update_observer.go

lumtis

Also, we can use a #nosec for the raised gosec issue

changelog.md

Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>

cmd/zetaclientd/start.go

lumtis

👍

ws4charlie

LGTM

* feat: zeta supply checks (#1358) * chore: improve changelogs format (#1390) * sort changelogs * refactor format * comment * fix(`crosschain`): use event index in inbound tx digest (#1372) * add event index in observer inbound * rename messages * update method usage * use event index * fix cosmos-gosec * depositor contract * smoketest refactor * fix contracts * mutiple deposits smoke tests * fix depositor * withdrawer contract * fix smoketest deposits * fix withdrawer contract * multiple withdraw test * fix contracts * fix withdraws * update changelog * fix: cherry pick v10.1.x hotfix (minRelayTxFee and bitcoin mainnet/testnet address format) (#1367) * skip some more recent garbage outTx trackers * skip garbage trackers and increase btc gas fee * skip mainnet addresses in cctxs * cherry picked minRelayTxFee hotfix and bitcoin testnet/mainnet address format fix * resolve conflict * update CHANGELOG.md for v10.1.x hotfix --------- Co-authored-by: charliec <charliec@zetachain.com> Co-authored-by: brewmaster012 <88689859+brewmaster012@users.noreply.github.com> * feat: update observer (#1384) * chore: add chain id to localnet and open port 26657 to make local testing easier. (#1401) * added chain id to configs * mapped port 26657 to localhost * feat: Add HSM capability for zetaclient hot key - non production (#1387) * initial commit * Added sign function and unit test * hsm config updates * introduce hsm mode * added commands to get address and generate key in hsm * skipping unit test as it will fail in CI * ran make generate and fixed lint errors * Update cmd/zetaclientd/hsm.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update zetaclient/broadcast.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update zetaclient/broadcast.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update zetaclient/hsm_signer.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update zetaclient/hsm_signer.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update zetaclient/hsm_signer.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * cleanup * added config for hsm hotkey name and moved hsm mode flag to zetabridge cfg * add entry to changelog. * moved hsm to new package and added build flag for unit test * add changelog entry * fix lint errors --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * fix: speed up evm outtx inclusion and improve log prints (#1406) Co-authored-by: charliec <charliec@zetachain.com> * docs: add code freeze note (#1414) * zetaclient: allow one 1 event that remotely calls zEVM contract per tx * revert the accidental last commit * include bitcoin outtx regardless of the cctx status (#38) * refactor: condense logging for a supply checker (#9) * chore: increment handler version (#5) Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * test: add tests for out tx tracker (#10) * add tests fro out ts tracker * use getEthereumChainID function in tests --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * fix: Zellic-3.7 - Add check for existing contract address to avoid overwriting. (#13) * add check for existing contract address to avoid overwriting. * Added check for redeployment of gas and asset token contracts Added unit test for this scenario * update changelog --------- Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * fix: Zellic-3.2 - prevent deposit when zrc20 is paused (#31) * add pause check * revert on paused * update tests * add smoke test check * goimports * changelog * Update x/crosschain/keeper/evm_deposit.go Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> --------- Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> * test: ballot tests (#17) * refactor(`fungible`): use code hash in `MsgUpdateContractBytecode` to allow for rollback (#23) * code hash request * make generate * udpate message * add cli command * udpate smoke tests * changelog * update message name * add check for length * replace log with event * add is contract check * refactor: consolidate builds (#22) * remove begin block * remove build from smoketest * deploy system contracts message * msg tx * add system contract deployment in smoke tests * start core params refactor * changelog * refactor chains * config refactor * remaining build tags * lint issues * lint issues 2 * gen docs * gen docs 2 * gosec issues 1 * fix cosmos nosec * lint issues * fix core params check * make generate * fix assign * use privnet chains by default * fix chain fetching * use local goerli for smoke tests * remove unamed gosec * address nosec * other goerli net to rename in smoketests * gosec * nosec alerts * nosec alert 2 * use Bitcoin specific network * fix address system contracts * add logs in test * Add more logs * test remaining smoke tests * remove hardcoded ZetaChain chain ID * remove bitcoin hardcoded values * add back smoketests * fix smoke test except cross chain swap * make generate * add log message * fix evm swap contract * fix unit test 1 * fix CLI tests * make generate * fix log error * fix Bitcoin proof test * fix address test * remove network flag and improve smoke tests * add admin group * move core params out of genesis * remove unnecessary RemoveInTxTrackerIfExists * add check for contract failure * Update x/crosschain/keeper/keeper_cross_chain_tx_vote_inbound_tx.go Co-authored-by: Tanmay <tanmay@zetachain.com> * fix install in action * improve events for system contract deploy * error handling for bitcoin net params * add utility functions in common * add stateful smoketest from source * try test fix * fix unit test * fix tests --------- Co-authored-by: Tanmay <tanmay@zetachain.com> * refactor: disable zeta supply checker routine (#45) * docs: update changelog with v11.0.0 * chore: update go releaser --------- Co-authored-by: Tanmay <tanmay@zetachain.com> Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> Co-authored-by: charliec <charliec@zetachain.com> Co-authored-by: brewmaster012 <88689859+brewmaster012@users.noreply.github.com> Co-authored-by: Charlie <31941002+CharlieMc0@users.noreply.github.com> Co-authored-by: kevinssgh <79858682+kevinssgh@users.noreply.github.com>

kingpinXD added 4 commits November 2, 2023 12:59

start coreobserver for tss signing

cdcb3b1

add new transaction to update operator address of observer

8d17a72

rebase develop

fa5a475

rebase develop

336a219

github-actions bot added breaking:proto breaking:cli labels Nov 7, 2023

github-actions bot added the nosec label Nov 7, 2023

Merge branch 'develop' into debug-update-observer

31b3c95

kingpinXD marked this pull request as ready for review November 7, 2023 22:30

kingpinXD requested review from brewmaster012, kevinssgh, fadeev, lumtis and ws4charlie as code owners November 7, 2023 22:30

kingpinXD marked this pull request as draft November 7, 2023 22:34

kingpinXD changed the title ~~Debug update observer~~ feat: update observer Nov 7, 2023

kingpinXD linked an issue Nov 8, 2023 that may be closed by this pull request

observer : Update Observer mechanism #1348

Closed

kingpinXD added 2 commits November 7, 2023 22:41

add more unit tests

b668d63

Merge remote-tracking branch 'origin/debug-update-observer' into debu…

09b42ae

…g-update-observer

kingpinXD marked this pull request as ready for review November 8, 2023 03:41

kingpinXD added 3 commits November 7, 2023 22:46

add logs for when node is active

a29d161

add check for tombstoned validator for observer votes

bda0742

add more checks for authorization of votes

139b092

lumtis reviewed Nov 8, 2023

View reviewed changes

kingpinXD added 2 commits November 10, 2023 11:33

add more test case for update observer

e00aa6d

rebase develop

75808f7

kingpinXD requested a review from lumtis November 10, 2023 16:44

kingpinXD added 3 commits November 10, 2023 12:21

add changelog

979232f

add an unreleased section in changelog.md

d9aa5a3

rebase develop

16f79b8

lumtis reviewed Nov 10, 2023

View reviewed changes

proto/observer/observer.proto Outdated Show resolved Hide resolved

x/observer/types/message_update_observer.go Show resolved Hide resolved

lumtis reviewed Nov 10, 2023

View reviewed changes

add additional test case for worng update reason

44ad77c

ws4charlie reviewed Nov 10, 2023

View reviewed changes

changelog.md Outdated Show resolved Hide resolved

kingpinXD and others added 3 commits November 10, 2023 18:19

add nosec

cb94bc7

Update changelog.md

2f700c1

Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>

register new tx in codec.go

0a969f9

ws4charlie reviewed Nov 11, 2023

View reviewed changes

cmd/zetaclientd/start.go Show resolved Hide resolved

lumtis approved these changes Nov 11, 2023

View reviewed changes

rebase develop

f17157f

ws4charlie approved these changes Nov 13, 2023

View reviewed changes

Merge branch 'develop' into debug-update-observer

fb63248

kingpinXD merged commit ce3cc5f into develop Nov 14, 2023
14 of 15 checks passed

kingpinXD deleted the debug-update-observer branch November 14, 2023 21:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update observer #1384

feat: update observer #1384

kingpinXD commented Nov 7, 2023 •

edited

github-actions bot commented Nov 7, 2023 •

edited

lumtis commented Nov 8, 2023

lumtis left a comment

lumtis left a comment

kingpinXD commented Nov 8, 2023

lumtis left a comment

lumtis left a comment

lumtis left a comment

ws4charlie left a comment

feat: update observer #1384

feat: update observer #1384

Conversation

kingpinXD commented Nov 7, 2023 • edited

Description

Type of change

How Has This Been Tested?

Checklist:

github-actions bot commented Nov 7, 2023 • edited

lumtis commented Nov 8, 2023

lumtis left a comment

Choose a reason for hiding this comment

lumtis left a comment

Choose a reason for hiding this comment

kingpinXD commented Nov 8, 2023

lumtis left a comment

Choose a reason for hiding this comment

lumtis left a comment

Choose a reason for hiding this comment

lumtis left a comment

Choose a reason for hiding this comment

ws4charlie left a comment

Choose a reason for hiding this comment

kingpinXD commented Nov 7, 2023 •

edited

github-actions bot commented Nov 7, 2023 •

edited