Compatibility with recent PHPUnit (8) #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamdes
approved these changes
Oct 30, 2020
derickr
requested changes
Oct 30, 2020
There was a problem hiding this comment.
I missed this PR, sorry. But running this with PHPUnit 8(.5.8) gives the following warnings too:
$ ./vendor/bin/phpunit
PHPUnit 8.5.8 by Sebastian Bergmann and contributors.
..........W.................................................... 63 / 754 ( 8%)
............................................................... 126 / 754 ( 16%)
.........................................................WWW..W 189 / 754 ( 25%)
WWW..W......................................W.................. 252 / 754 ( 33%)
............................................................... 315 / 754 ( 41%)
............................................................... 378 / 754 ( 50%)
..........W.................................................... 441 / 754 ( 58%)
............................................................... 504 / 754 ( 66%)
............................................................... 567 / 754 ( 75%)
............................................................... 630 / 754 ( 83%)
............................................................... 693 / 754 ( 91%)
............................................................. 754 / 754 (100%)
Time: 1.03 seconds, Memory: 12.00 MB
There were 11 warnings:
1) ezcConsoleArgumentsTest::testOffsetUnsetSuccess
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
2) ezcConsoleOptionTest::testAddDependency
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
3) ezcConsoleOptionTest::testRemoveDependency
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
4) ezcConsoleOptionTest::testRemoveAllDependencies
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
5) ezcConsoleOptionTest::testResetDependencies
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
6) ezcConsoleOptionTest::testAddExclusion
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
7) ezcConsoleOptionTest::testRemoveExclusion
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
8) ezcConsoleOptionTest::testRemoveAllExclusions
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
9) ezcConsoleOptionTest::testResetExclusions
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
10) ezcConsoleOutputFormatsTest::testIterator
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
11) ezcConsoleStatusbarTest::testReset
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
Would you have time to look at that? I also had to update composer.json to change the phpunit line to "~8.0"
I would say Why: because your tests are run on Debian or other packaging systems that can still use phpunit 7 |
|
I've bumped the PHP Unit requirement to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.