Creates api proxy #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardolsson
approved these changes
Jan 12, 2021
| return [ | ||
| { | ||
| source: '/api/:slug*', | ||
| destination: 'https://api.zetk.in/v1/:slug*', |
There was a problem hiding this comment.
The URL to the Zetkin API should be externalized eventually, so that we can toggle between using the development environment and the live environment.
| @@ -5,13 +5,13 @@ import { QueryClient, useQuery } from 'react-query'; | |||
| function getEvents(orgId) { | |||
| return async () => { | |||
| try { | |||
| const cRes = await fetch(`http://api.zetk.in/v1/orgs/${orgId}/campaigns`); | |||
| const cRes = await fetch(`http://localhost:3000/api/orgs/${orgId}/campaigns`); | |||
There was a problem hiding this comment.
The domain (as well as scheme/protocol and port) of the app should be externalized eventually, so that it can be run with other settings in production.
This was referenced Jan 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #7 .