-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event feature testing #2021
Event feature testing #2021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! I have no required changes, but some suggestions below. 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have looked at the recent changes and they look good. I think it's time to merge!
Description
This PR started out as working on #1994 but evolved into the start of a way to test whole features. This is not a complete test suite that covers all states and situations an event goes through, but it is a beginning to figuring out ways to make hour hooks and stores testable together.
Screenshots
Behold the glorious absence of spinner 😅
Changes
Notes to reviewer
none
Related issues
Resolves #1994 (once and for all, hopefully)