Fix linux detection #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @zevilz Any news about this? |
|
I wouldn't mind his signature on Author name. He is already taking full responsibility for this repository. At least my contribution was not a lot nor I think I am an expert in answering any questions regarding this repository. Next, Linux detection codes look good to me. |
|
@zevilz Why this was closed? The issue this is aiming to fix still exists. If it's for the copyright thing, why not tell me so I can drop that commit? |
|
@zevilz Dropped the commit and rebased with latest master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux wasn't detected correctly in my Raspberry Pi device as the returned string in
OSTYPEislinux-gnueabihfinstead oflinux-gnuRemoved also the author block as I saw that there are other contributions from other people throughout the commit history, so the authors of the code are not only you but also @incrementing and @VarunBatraIT. People looking for the full history of contributions can directly check in https://github.com/zevilz/zImageOptimizer/graphs/contributors