Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scopes #82

Merged
merged 4 commits into from
Feb 25, 2017
Merged

Scopes #82

merged 4 commits into from
Feb 25, 2017

Conversation

basz
Copy link
Collaborator

@basz basz commented Feb 25, 2017

This PR fixes a bug where requesting tokens with a scope would fail due to incorrect arguments

Additionally; I've limited the scope arguments to arrays with strings or Scope's and changed the method used Scope to strings are handled via an array_map (string) call

@basz basz requested a review from prolic February 25, 2017 17:23
@coveralls
Copy link

coveralls commented Feb 25, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 99.789% when pulling a8af469 on basz:scopes into 36b07e3 on zf-fr:master.

@coveralls
Copy link

coveralls commented Feb 25, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 0fee677 on basz:scopes into 36b07e3 on zf-fr:master.

@prolic prolic merged commit beb8a89 into zf-fr:master Feb 25, 2017
@basz basz deleted the scopes branch February 25, 2017 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prolic prolic prolic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basz @coveralls @prolic