Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php8 Zend_Log compatibility fixes #107

Merged
merged 3 commits into from
Oct 1, 2021
Merged

php8 Zend_Log compatibility fixes #107

merged 3 commits into from
Oct 1, 2021

Conversation

falkenhawk
Copy link
Member

  • prevent fatal error on php8 on invalid streamOrUrl passed to Zend_Log_Writer_Stream constructor
  • prevent fatal error on php8 on invalid mode passed to Zend_Log_Writer_Stream constructor
  • prevent fatal error on php8 on write when there is an issue with stream (e.g. closed or unusable)

refs:

@falkenhawk
[zend-log] prevent fatal error on php8 on invalid streamOrUrl
b0851dd 
passed to Zend_Log_Writer_Stream constructor
@falkenhawk
[zend-log] prevent fatal error on php8 on invalid mode
55d900c 
passed to Zend_Log_Writer_Stream constructor
@falkenhawk
[zend-log] prevent fatal error on php8 on write
72b6ed6 
when there is an issue with stream (e.g. closed or unusable)
This was referenced Sep 26, 2021
Closed
Closed
@marcing marcing self-requested a review October 1, 2021 08:24
@falkenhawk falkenhawk changed the base branch from fix-zend-db-php8 to master October 1, 2021 08:24
@falkenhawk falkenhawk merged commit eb9e6c4 into master Oct 1, 2021
@falkenhawk falkenhawk deleted the fix-zend-log-php8 branch October 1, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcing marcing marcing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@falkenhawk @marcing