Zend_Log: catch TypeError/ValueError for PHP 8.0

[glensc]

Similar to #85, catch TypeError/ValueError being thrown from PHP 8.0 from invalid arguments and convert to appropriate Zend_Exception.

refs:

• PHP 8.0 porting status #51

[glensc]

So, there's such test:

• zf1/tests/Zend/Log/Writer/StreamTest.php

  Lines 49 to 60 in 8e1040b

  	public function testConstructorThrowsWhenResourceIsNotStream()
  	{
  	$resource = xml_parser_create();
  	try {
  	new Zend_Log_Writer_Stream($resource);
  	$this->fail();
  	} catch (Exception $e) {
  	$this->assertTrue($e instanceof Zend_Log_Exception);
  	$this->assertRegExp('/not a stream/i', $e->getMessage());
  	}
  	xml_parser_free($resource);
  	}

And this no longer returns a resource but a XmlParser class: $resource = xml_parser_create()

The test expected this code path to be executed:

• zf1/packages/zend-log/library/Zend/Log/Writer/Stream.php

  Lines 61 to 65 in 8e1040b

  	if (is_resource($streamOrUrl)) {
  	if (get_resource_type($streamOrUrl) != 'stream') {
  	// require_once 'Zend/Log/Exception.php';
  	throw new Zend_Log_Exception('Resource is not a stream');
  	}

but instead it ends up here, with open throwing with TypeError:

• zf1/packages/zend-log/library/Zend/Log/Writer/Stream.php

  Lines 78 to 82 in 8e1040b

  	if (! $this->_stream = @fopen($streamOrUrl, $mode, false)) {
  	// require_once 'Zend/Log/Exception.php';
  	$msg = "\"$streamOrUrl\" cannot be opened with mode \"$mode\"";
  	throw new Zend_Log_Exception($msg);
  	}

Failed asserting that 'fopen(): Argument #1 ($filename) must be of type string, XmlParser given' matches PCRE pattern "/not a stream/i".

@falkenhawk: how to proceed here?

[glensc]

to keep the most backward compatible way, would need to change code to reach also code path where is_resource is true, but I can't just add instanceof XmlParser there! :D

[glensc]

The current assertions are something like this:

/Users/glen/.local/bin/php80 /private/var/folders/_x/06xnfg5j58s_qvckwbk31x8w0000gn/T/ide-phpunit.php --configuration /Users/glen/scm/php/zf1/zf1s/phpunit.xml.dist --filter Zend_Log_Writer_StreamTest --test-suffix StreamTest.php /Users/glen/scm/php/zf1/zf1s/tests/Zend/Log/Writer
Testing started at 20:28 ...
PHPUnit 3.7.38 by Sebastian Bergmann.

Configuration read from /Users/glen/scm/php/zf1/zf1s/phpunit.xml.dist

F...F.FF...

Time: 76 ms, Memory: 4.00Mb

There were 4 failures:

1) Zend_Log_Writer_StreamTest::testConstructorThrowsWhenResourceIsNotStream
Failed asserting that 'fopen(): Argument #1 ($filename) must be of type string, XmlParser given' matches PCRE pattern "/not a stream/i".

/Users/glen/scm/php/zf1/zf1s/tests/Zend/Log/Writer/StreamTest.php:57
/Users/glen/scm/php/zf1/zf1s/vendor/zf1s/phpunit/composer/bin/phpunit:63

2) Zend_Log_Writer_StreamTest::testConstructorThrowsWhenStreamCannotBeOpened
Failed asserting that 'Path cannot be empty' matches PCRE pattern "/cannot be opened/i".

/Users/glen/scm/php/zf1/zf1s/tests/Zend/Log/Writer/StreamTest.php:92
/Users/glen/scm/php/zf1/zf1s/vendor/zf1s/phpunit/composer/bin/phpunit:63

3) Zend_Log_Writer_StreamTest::testWriteThrowsWhenStreamWriteFails
Failed asserting that 'fwrite(): supplied resource is not a valid stream resource' matches PCRE pattern "/unable to write/i".

/Users/glen/scm/php/zf1/zf1s/tests/Zend/Log/Writer/StreamTest.php:122
/Users/glen/scm/php/zf1/zf1s/vendor/zf1s/phpunit/composer/bin/phpunit:63

4) Zend_Log_Writer_StreamTest::testShutdownClosesStreamResource
Failed asserting that 'fwrite(): supplied resource is not a valid stream resource' matches PCRE pattern "/unable to write/i".

/Users/glen/scm/php/zf1/zf1s/tests/Zend/Log/Writer/StreamTest.php:138
/Users/glen/scm/php/zf1/zf1s/vendor/zf1s/phpunit/composer/bin/phpunit:63

FAILURES!
Tests: 11, Assertions: 14, Failures: 4.

Process finished with exit code 1

It's difficult to see these in CI, as unexpected errors from #85 shadow tests in #88 and vice versa.

[glensc]

ping @falkenhawk

[falkenhawk]

@glensc perhaps transform this else

zf1/packages/zend-log/library/Zend/Log/Writer/Stream.php

Line 73 in 8e1040b

} else {

into e.g.
else if (is_string($streamOrUrl) || is_array($streamOrUrl)) {
and add additional else block at the end to catch the rest?

else {
  throw new Zend_Log_Exception('Resource is not a stream');
}

🤔

[falkenhawk]

superseded by #107