Reduce redundant else-branching (after throws), add missing @throws annotations

[glensc]

Carry Shardj/zf1-future#104.

• Excluded whitespace and formatting changes.
• Included extra fixes:
  • https://github.com/Shardj/zf1-future/pull/104/files#r992515043
  • https://github.com/Shardj/zf1-future/pull/104/files#r992486395

cc @kstenschke

[glensc]

php 8.0 job needs retry. i don't have permission to do so myself. some temporary error setting up container.

[falkenhawk]

@glensc @throws tags are useful indeed.

But do we really need all the code beautifying? let the zf1 be the ugly beast, only taming it to make it work without errors on newer php versions. I don't want to follow the path of others trying to make the codebase look cleaner or more modern :)

[falkenhawk]

or is it a matter of a IDE complaining there, for redundant else after return, when using zf1 in a project?

[glensc]

that's the thing, we don't need, but doing so makes it easier to pull changes from the other repo if the codebase is not that diverged. i reviewed the diffs here many times, these seem to do what they describe. no extra code, no side effects.

[glensc]

I already excluded whitespace and formatting changes (if you open the original pull request), which makes merging the codebase more difficult again, but at least diff -w might help (haven't tested)

[glensc]

Extracted annotations:

• Add missing @throws annotations #140

so you can decide about the other changes here later.

[falkenhawk]

Oh that's lovely, thanks @glensc . I will look into it

[falkenhawk]

decided to go with #140 instead