Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing @throws annotations #140

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Oct 12, 2022

Carry only @throws annotations from #138

Which itself was to carry Shardj/zf1-future#104:

cc @kstenschke

kay.stenschke and others added 2 commits October 12, 2022 22:44
@glensc
Copy link
Contributor Author

glensc commented Nov 7, 2022

@falkenhawk such trivial change which you approved in words but still not merged? I had some idea to carry changes from zf1-future, but if the process is blocked such trivial changes, it really demotivates and questions should this fork just be marked abandoned. or increase the developer team size who can actually approve and merge things?

@falkenhawk
Copy link
Member

@glensc I appreciate your expression of disappointment, I'd love to be more involved, and also we have few people in the team with access to push/create pull requests/reviews, but it is not trivial to just allocate time to manage it. (or to find enough motivation)

I guess your comment was meant to be a motivational one, but it is difficult not to take it personal. I want to believe that perhaps you are affected by not having a particularly great day today, or maybe it is just me, being a bit vulnerable by not having a good time at this moment either.

Not actioning on the repo for past 4 weeks is far from abandoning it, I would say.

@falkenhawk
Copy link
Member

falkenhawk commented Nov 7, 2022

Not actioning on the repo for past 4 weeks is far from abandoning it, I would say.

and it is not only your PR, as you may see also PRs created by me myself are not merged yet. (also small and trivial ones) and a bigger one (i.e. #141 ) still awaits a free time slot in one's free time to take care of.

Anyway, I should not even feel pushed to spend my time on writing such comments. could we try to encourage each other (as I've been always trying to by even commenting with a word of appreciation on every issue and PR created here) and put toxicity aside, please.

Copy link
Member

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the comments above, thanks a lot for setting up this PR, as discussed in #138 to avoid additional code structure changes which are not necessary in our approach, I really appreciate it.

As you probably saw I could've only put a heart emoji on the PR description before forgetting about it and proceeding with my daily chores. So indeed this PR needed a reminder to get my attention back, and to merge it after pending for 26 days since it was created

@falkenhawk falkenhawk merged commit 9a47ff0 into zf1s:master Nov 7, 2022
@falkenhawk falkenhawk mentioned this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants