Remove usage of $php_errormsg

[Megatherium]

The track_errors directive and the global $php_errormsg variable have been removed in PHP8. The same functionality can be achieved via error_get_last() thereby making the framework compatible with PHP8 in this respect.

closes #35

[glensc]

Version info:

• https://www.php.net/error_get_last

(PHP 5 >= 5.2.0, PHP 7)

[glensc]

typo in commit message: beeb

[glensc]

@Megatherium there is some side effect on this, $php_errormsg is local to function/method, but error_get_last() is global, so if previous code was able to check $php_errormsg if error has happened, then in new code, error_get_last() must be called only if it is certain that error has occoured.

have you considered this in the changes you made?

there is error_clear_last(), but that's php7, but there's polyfill for that:

• https://github.com/symfony/polyfill-php70

we would not need that error clearing method if the "use error_get_last() only on errors" principle is followed.

[glensc]

@Megatherium there are some totally new tests added with this PR. where they originate from? perhaps submit them as separate PR and leave credits/info?

[glensc]

@Megatherium also, please rebase your branch against current master. this is to ensure CI stays green even after the merge.

[Megatherium]

have you considered this in the changes you made?

No, I was unaware of this distinction. I will look into it.

there are some totally new tests added with this PR. where they originate from?

I added them. I assume to test my changes but it's been a while...

please rebase your branch against current master. this is to ensure CI stays green even after the merge.

Will try.

[glensc]

there are some totally new tests added with this PR. where they originate from?

I added them. I assume to test my changes but it's been a while...

Ah okay, It's okay then

[glensc]

@Megatherium @falkenhawk please add "closes #35" to PR body. I don't have administrative privileges to do so myself.

[glensc]

@Megatherium you need to add "symfony/polyfill-php70" to each subpackage composer.json, where you used error_clear_last().

[Megatherium]

@Megatherium you need to add "symfony/polyfill-php70" to each subpackage composer.json, where you used error_clear_last().

Done.

Also: 5.4 and 5.5 finish flawlessly over on Travis. Github seems to have mangled their images.

[glensc]

Reported about ext-ldap again:

• ext-ldap fails to enable on 5.4/5.5 shivammathur/setup-php#407

[glensc]

@Megatherium so here's an example that I had in mind. this code block does not need error_clear_last(), as the error_get_last() is called only if the error happens.

        error_clear_last();
        $feed = @file_get_contents($filename);
        if ($feed === false) {
            /**
             * @see Zend_Feed_Exception
             */
            $err = error_get_last();
            $phpErrormsg = isset($err['message'][0]) ? $err['message'] : null;
            throw new Zend_Feed_Exception("File could not be loaded: $phpErrormsg");
        }
        return self::importString($feed);

But as the new dependency was introduced, I guess it's best to just call it anyay, to be sure the code doesn't break on future code changes.

[glensc]

@Megatherium can you re-run the CI, as it seems to be a temporary issue:

• ext-ldap fails to enable on 5.4/5.5 shivammathur/setup-php#407 (comment)

[Megatherium]

FYI The last commit just contained an extra blank like to trigger the CI.

[falkenhawk]

Thank you very much for your ongoing commitment @Megatherium and @glensc!

[falkenhawk]

oh. perhaps I should have waited for #32 to be merged first 🙈

[glensc]

FYI The last commit just contained an extra blank like to trigger the CI.

1. you don't need to commit. there's re-run all jobs in actions web ui
2. you can also git commit --amend && git push --force-with-lease, which is sufficient if the commit date changes to make a new commit hash.

[glensc]

oh. perhaps I should have waited for #32 to be merged first 🙈

these are standalone changesets. The problem with #32 is that it's a too big bite to take a time, and is still not reviewed/merged.

I thought to extract changes from there into separate PR if I have time, but apparently, I don't.

[Megatherium]

FYI The last commit just contained an extra blank like to trigger the CI.

1. you don't need to commit. there's re-run all jobs in actions web ui

True but not for me on this repo. Probably a rights thing.

2. you can also `git commit --amend && git push --force-with-lease`, which is sufficient if the commit date changes to make a new commit hash.

Good to know.

[glensc]

1. you don't need to commit. there's re-run all jobs in actions web ui

True but not for me on this repo. Probably a rights thing.

You need to go to your fork Actions tab. jobs from there are retry-able.